666465 - IonMonkey: Add JSON dump for easier parsing by visualization tools

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Drake [:adrake]]

Parsing C1Visualizer spew is difficult and the format is insufficiently expressive for everything we'd like to do with IonMonkey data visualization. This patch adds a JSON formatted spew for use by visualization tools which can be easily changed and extended.

Comment 1

[Andrew Drake [:adrake]]

Attachment: Patch v0

Emits some basic instruction and block information. Also serves as a base for interval spewing for the register allocator.

Comment 2

[Ryan Pearl [:rpearl]]

Didn't you write a visualizer for live ranges as well?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 541246 [details] [diff] [review]
Patch v0

Review of attachment 541246 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/Ion.cpp
@@ +163,5 @@
>      spew.spew("Generate LIR");
> +    jsonspew.beginPass("Generate LIR");
> +    jsonspew.spewMIR(&graph);
> +    jsonspew.spewLIR(&graph);
> +    jsonspew.endPass();

Hrm. This will get kind of annoying. Could you piggyback the jsonspew through the C1 spew? Alternately, create some kind of generic spew interface (spewer->SpewPass("blah")) and choose a spew mechanism ahead of time.

::: js/src/ion/JSONSpewer.h
@@ +51,5 @@
> +namespace ion {
> +
> +class JSONSpewer
> +{
> +private:

Nit: two-space indent here, and for the "public" below.

@@ +76,5 @@
> +
> +public:
> +    JSONSpewer() :
> +      first_(true)
> +    { }

Extreme nit: I'm not sure what the house style is for constructors anymore, but it'd be good to have consistency. I've been doing:

   Name() : singleItem(singleItem)
   { }

   Or,
   Name()
     : item1(item1),
       item2(item2)
   { }

@@ +92,5 @@
> +    void endPass();
> +
> +    void endFunction();
> +
> +    void finish();

Nit: I would cram all these functions together, no need to separate them all with newlines.

Comment 4

[Andrew Drake [:adrake]]

(In reply to comment #2)
> Didn't you write a visualizer for live ranges as well?

Yes, but live ranges don't exist outside of the patch in my queue yet. Also, that would be a new bug.

Comment 5

[Andrew Drake [:adrake]]

http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/45251f570996