As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 666502 - Document how we make sure HTTP headers have been read by time OnStartRequest called.
: Document how we make sure HTTP headers have been read by time OnStartRequest ...
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: unspecified
: All All
: -- minor (vote)
: mozilla7
Assigned To: Nobody; OK to take it and work on it
: Patrick McManus [:mcmanus]
Depends on:
  Show dependency treegraph
Reported: 2011-06-22 22:29 PDT by Jason Duell [:jduell] (needinfo me)
Modified: 2011-06-24 02:53 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Comment-only patch (2.50 KB, patch)
2011-06-22 22:29 PDT, Jason Duell [:jduell] (needinfo me)
bzbarsky: review+
Details | Diff | Splinter Review

Description User image Jason Duell [:jduell] (needinfo me) 2011-06-22 22:29:09 PDT
Created attachment 541286 [details] [diff] [review]
Comment-only patch

This took me a while to figure out, so I figured I'd improve the comments to make it clearer how we guarantee the HTTP headers are parsed by the time mTransactionPump starts receiving input.
Comment 1 User image Boris Zbarsky [:bz] (still a bit busy) 2011-06-23 00:14:58 PDT
Comment on attachment 541286 [details] [diff] [review]
Comment-only patch

Comment 2 User image Jason Duell [:jduell] (needinfo me) 2011-06-23 14:44:30 PDT
Comment 3 User image Marco Bonardo [::mak] 2011-06-24 02:53:58 PDT

Note You need to log in before you can comment on or make changes to this bug.