666596 - should be able to add cases to a suite at time of creation

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: MozTrap, enhancement)

Description

[Cameron Dawson [:camd]]

I see the user workflow being like this:

A user is assigned to test a feature of the product.
So they want to write a bunch of test cases for that feature.
They want to create the Test Suite that represents that feature,
then write case after case to test it.

It is cumbersome to create all your test cases first, then create the suite and have to go back later and find the cases that should belong to it.

Comment 1

[Cameron Dawson [:camd]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/14937235

Comment 2

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
relates to: https://www.pivotaltracker.com/story/show/14300395

Comment 4

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
I think Vadim added this functionality to the platform now.

Comment 5

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
https://bugzilla.mozilla.org/show_bug.cgi?id=670698

Comment 6

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
So the wireframe here should just be a "suite" dropdown in the new-test-case form (but not the case-edit form).

What about bulk test case creation form? Do we need the suite dropdown there too, and it applies to all the bulk-created cases?

Comment 7

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
carl: yes, definitely to bulk, too.

since cases can be included in many suites, my preference would be to use the multi-select widget to specify which suites a case belongs to.  And that would be on the create as well as edit form (if possible) single as well as bulk.

Comment 8

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
Ok, this is a much bigger story than I was anticipating, then. I think it's all doable, but not by the Nov 15 dogfooding deadline. Are there any parts of this that could be pushed later? 

The case edit page is quite different from the case-create pages, so suite-selection on case edit should be a separate story from suite-selection on case create; this story specifically says its about "at creation time."

I'm not confident of getting the multi-select widget repurposed for this use (selecting suites instead of selecting cases) in time for Nov 15, even if its just on the create pages. We could try.

Comment 9

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
carl: that's fair.  OK, for now, in this story, let's just have a drop down field in create bulk and single for a suite to add the case(s) to.  I'll create a new story for the multi-selecting

Comment 10

[Cameron Dawson [:camd]]

Eric Meyer changed story state to started in Pivotal Tracker

Comment 11

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
skipping the wireframe approval stage here, since it's just a dropdown. Cam, let me know if you want to check this out before I implement.

Comment 12

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
merged this back to master. 

eric, looks like we currently don't have visual distinction between required and non-required select fields, nor do you have a class available to you to allow you to make that distinction. For non-select fields there's a class on the input and we use HTML5 validation and slick colors to indicate, but the colors don't seem to work on the select boxes (at least in FF). Should we do something like un-bold the label for required fields? Where would you want a class in order to make that happen?

jonny: this will also need some JS to filter the suite options to the ones for the selected product, just like filterFormOptions already does for cases-in-suite. Using data-product-id on the choices, the markup's the same.

Comment 13

[Cameron Dawson [:camd]]

Eric Meyer added a comment in Pivotal Tracker:   
   
Required should be an attribute on the select element, not a class anywhere. And I can use text color to show validation in selections, which will work similar to the box-shadow on inputs. The only problem is that we have an HTML5 valid <option> "----------" that we don't want to accept as valid, so we will need to have our own check for that. All I need is the "hadfocus" class that we already get on inputs, and a new "valid" or "invalid" class based on the selection. both should be applied to the <select> element itself.

Comment 14

[Cameron Dawson [:camd]]

Eric Meyer added a comment in Pivotal Tracker:   
   
I take that back. This seems to all be working without any JS help at all.

Comment 15

[Cameron Dawson [:camd]]

Eric Meyer changed story state to finished in Pivotal Tracker

Comment 16

[Cameron Dawson [:camd]]

Carl Meyer changed story state to delivered in Pivotal Tracker

Comment 17

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Hmm, in bulk mode, the suite drop down never has anything in it.  just the "----" item.

Comment 18

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
works great in single mode, though.

Comment 19

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
sorry to reject.  please fix bulk mode suite selection.

Comment 20

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to rejected in Pivotal Tracker

Comment 21

[Cameron Dawson [:camd]]

Carl Meyer changed story state to started in Pivotal Tracker

Comment 22

[Cameron Dawson [:camd]]

Carl Meyer changed story state to finished in Pivotal Tracker

Comment 23

[Cameron Dawson [:camd]]

Carl Meyer changed story state to delivered in Pivotal Tracker

Comment 24

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
Fixed the bulk form.

Comment 25

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker