666706 - Don't pass IPv6 literals to the effective TLD service, since the brackets prevent them from being recognized as IPs

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Dão Gottwald [:dao]]

Attachment: tests

I generated the attached tests based on <http://hg.mozilla.org/mozilla-central/rev/8b5646a07963>. The eTLD service fails for every host containing a dot, e.g. [::192.168.1.1], for which it considers "1.1]" to be the base domain.

Comment 1

[Dão Gottwald [:dao]]

Or maybe the problem is that I'm passing the host with the brackets to getBaseDomainFromHost?

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

There's PR_StringToNetAddr logic in nsEffectiveTLDService::GetBaseDomainInternal that I would assume should be catching this. Does it just not handle the bracket format? I'm not very familiar with ipv6 IP address formats.

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> There's PR_StringToNetAddr logic in
> nsEffectiveTLDService::GetBaseDomainInternal that I would assume should be
> catching this. Does it just not handle the bracket format? I'm not very
> familiar with ipv6 IP address formats.
IIRC it doesn't handle that format.

Comment 5

[Dão Gottwald [:dao]]

Passing them without the brackets to getBaseDomainFromHost works, but removing the brackets in order to do that would be pointless, as getBaseDomainFromHost would just throw anyway.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

getBaseDomainFromHost should probably also throw when the brackets are included, rather than returning a bogus result.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 541604 [details] [diff] [review]
patch

can you file a followup for that and add a comment?

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/a8b1330b8ac9

filed bug 667159