Closed
Bug 666709
Opened 13 years ago
Closed 13 years ago
One or more places xpcshell tests modify in-tree default.sqlite
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: ted, Assigned: mak)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
855 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
If you run xpcshell-tests from your objdir on Linux, one or more of the Places tests modify default.sqlite: M toolkit/components/places/tests/unit/default.sqlite This might be due to the fact that it's a symlink there. This is bad, and we should fix it.
|
Assignee | |
Comment 1•13 years ago
|
||
mxr tells me this test does do_get_file("default.sqlite");
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/test_database_replaceOnStartup.js|
|
Assignee | |
Comment 2•13 years ago
|
||
I'll look into this bug.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #541681 -
Flags: review?(ted.mielczarek)
|
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 541681 [details] [diff] [review] patch v1.0 Thanks for the fix!
Attachment #541681 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/97e9557660e9
Whiteboard: [inbound]
|
|
Assignee | |
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/97e9557660e9
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•