If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

pushloghtml should only show first line of commit message, like other hg log tools

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: dbaron, Assigned: djc)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1018] )

Attachments

(1 attachment)

hg log tools in general show only the first line of the commit message in any log that shows multiple commits.  pushloghtml doesn't follow this convention, and thus discourages people from writing good descriptions of their changes in commit messages.

For an example of a changeset with the standard commit message format supported by hg, git, etc., which I think we should encourage, see:

http://hg.mozilla.org/mozilla-central/rev/830111e10951

The shortlog shows this correctly:
http://hg.mozilla.org/mozilla-central/shortlog/52476
as just:

L. David Baron - Change the blur radius for -moz-box-shadow and text-shadow to match what is specified in css3-background, and the blur radius for canvas to follow what is specified in HTML5. (Bug 590039) r=roc a2.0=blocking2.0:beta6 

The pushloghtml format shows the whole commit message:

L. David Baron — Change the blur radius for -moz-box-shadow and text-shadow to match what is specified in css3-background, and the blur radius for canvas to follow what is specified in HTML5. (Bug 590039) r=roc a2.0=blocking2.0:beta6 This fixes the multiplication by 1.5 in gfxAlphaBoxBlur::CalculateBlurRadius (originally added in changeset ce9f05b57b95 for bug 467518) to work correctly. It was previously a multiplication by 1 due to integer division. CalculateBlurRadius previously multiplied by 1.880; it now multiplies by 2.820. This changes canvas shadow handling to multiply shadowBlur by 2 before taking its square root, as described in the spec. This means that canvas shadow blurs 8px or smaller are 1.5 times larger than they were previously (due to the CalculateBlurRadius change), and canvas shadow blurs larger than 8px are 2.121 times larger than they were previously (due to the CalculateBlurRadius change *and* the additional factor of sqrt(2)). This changes text-shadow and -moz-box-shadow handling to use CalculateBlurRadius on half of the value given instead of passing the value through directly. This means that text-shadow and box-shadow blurs are multiplied by 1.410 relative to their old sizes. It also means that we round rather than floor, so that the effect that used to be drawn by a blur in the range 1px to 1.99px is now drawn by a blur anywhere in the range 0.36px to 1.05px, the effect that used to be drawn by a blur in the range 2px to 2.99px is now drawn by a blur anywhere in the range 1.06px to 1.77px, what used to be a drawn by a blur in the range 3px to 3.99px is now drawn by a blur anywhere in the range 1.78px to 2.47px, etc. 

when it should just be showing the first line of the commit message as shortlog and summary do.
Oops, forgot the pushloghtml link:
http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=830111e10951
(Assignee)

Comment 2

6 years ago
Created attachment 541629 [details] [diff] [review]
Patch

Agreed. Here's a patch.
Assignee: nobody → dirkjan
Status: NEW → ASSIGNED
Attachment #541629 - Flags: review?(ted.mielczarek)
Comment on attachment 541629 [details] [diff] [review]
Patch

Review of attachment 541629 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure why I did this originally, maybe I didn't know or understand what the default templates did.
Attachment #541629 - Flags: review?(ted.mielczarek) → review+
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/101]

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/101] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1009] [kanban:engops:https://kanbanize.com/ctrl_board/6/101]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1009] [kanban:engops:https://kanbanize.com/ctrl_board/6/101] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1017] [kanban:engops:https://kanbanize.com/ctrl_board/6/101]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1017] [kanban:engops:https://kanbanize.com/ctrl_board/6/101] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1018] [kanban:engops:https://kanbanize.com/ctrl_board/6/101]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1018] [kanban:engops:https://kanbanize.com/ctrl_board/6/101] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1018]

Comment 4

2 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/5685133c102fab561db6e885f4ca2beeb5b9f8cf
hgtemplates: only show first line of commit message in pushlog view (bug 666750)

Comment 5

2 years ago
Will deploy shortly.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
QA Contact: hwine
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.