Closed
Bug 666834
Opened 14 years ago
Closed 13 years ago
Remove (now dead) repackage-installer code from chatzilla makefiles
Categories
(Other Applications :: ChatZilla, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: ewong)
References
Details
Attachments
(2 files)
1.44 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
Callek
:
review-
|
Details | Diff | Splinter Review |
1.08 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
As noticed in Bug 666518 our repackage-win32-installer code in chatzilla is dead-code, and no longer needed.
This was last used for SeaMonkey's installer.
Assignee | ||
Comment 1•13 years ago
|
||
Taken w/ permission from Callek over irc.
Assignee: bugspam.Callek → ewong
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #582528 -
Flags: review?
Assignee | ||
Updated•13 years ago
|
Attachment #582528 -
Flags: review? → review?(silver)
Comment 3•13 years ago
|
||
Comment on attachment 582528 [details] [diff] [review]
Removed repackage-installer code from cZ makefiles.
I don't know this code but it looks okay. r=silver
Attachment #582528 -
Flags: review?(silver) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Pushed to chatzilla:
http://hg.mozilla.org/chatzilla/rev/62e1f497a4dd
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•13 years ago
|
||
Comment on attachment 582528 [details] [diff] [review]
Removed repackage-installer code from cZ makefiles.
Whops I did skim this, so can only blame myself, but we need this backed out, only the |repackage-win32-installer| parts should have gone, repackage-zip* needed to stay.
Ewong please backout when you get a chance (or just fix), no huge rush. It won't break aurora since I'll be getting the .88 tag of Chatzilla there
Attachment #582528 -
Flags: review-
Reporter | ||
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #583178 -
Flags: review?(bugspam.Callek)
Reporter | ||
Updated•13 years ago
|
Attachment #583178 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Pushed to chatzilla: http://hg.mozilla.org/chatzilla/rev/5ee16d62fb01
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•