Closed Bug 666869 Opened 9 years ago Closed 9 years ago

Crash [@ nsGlobalWindow::GetPerformance]

Categories

(Core :: DOM: Core & HTML, defect, critical)

defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla7

People

(Reporter: jruderman, Assigned: mounir)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, testcase)

Attachments

(4 files, 1 obsolete file)

No description provided.
Attached file stack trace
OS: Mac OS X → All
Hardware: x86_64 → All
Attached patch Simple fixSplinter Review
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #541644 - Flags: review?(Olli.Pettay)
Attached patch Simple fix with test (obsolete) — Splinter Review
Thanks for report and fix. Here's the same fix with added mochitest
(In reply to comment #3)
> Created attachment 541663 [details] [diff] [review] [review]
> Simple fix with test
> 
> Thanks for report and fix. Here's the same fix with added mochitest

You don't need a mochitest. I was planning to attach Jesse's testcase as a crashtest.
(In reply to comment #4)
> You don't need a mochitest. I was planning to attach Jesse's testcase as a
> crashtest.

By attach I mean push.
OTOH, maybe it's good to have it as a mochitest for the

  ok(frameWin.performance==null, 'Performance for non-existing frame???');
Attachment #541644 - Flags: review?(Olli.Pettay) → review+
Pushed to mozilla-inbound with the crashtest.

Igor, can you write a patch that adds the test mentioned in comment 6 to the current performance test suite?
Flags: in-testsuite+
Whiteboard: [inbound]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/070f95edc105
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
Attached patch Mochitest onlySplinter Review
I had this test as part of the previous patch. There is not much of test suite yet, and the existing test covers basic scenario, so mixing this test in doesn't feel right to me.
Attachment #541663 - Attachment is obsolete: true
Verified fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I loaded the test case from the description on the above builds and none of them crashed. There were no other issues either.
Status: RESOLVED → VERIFIED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.