The default bug view has changed. See this FAQ.

Crash [@ nsGlobalWindow::GetPerformance]

VERIFIED FIXED in mozilla7

Status

()

Core
DOM
--
critical
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: mounir)

Tracking

(Blocks: 1 bug, {crash, regression, testcase})

Trunk
mozilla7
crash, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 541626 [details]
testcase (crashes Firefox when loaded)
(Reporter)

Comment 1

6 years ago
Created attachment 541627 [details]
stack trace
(Assignee)

Updated

6 years ago
OS: Mac OS X → All
Hardware: x86_64 → All
(Assignee)

Comment 2

6 years ago
Created attachment 541644 [details] [diff] [review]
Simple fix
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #541644 - Flags: review?(Olli.Pettay)

Comment 3

6 years ago
Created attachment 541663 [details] [diff] [review]
Simple fix with test

Thanks for report and fix. Here's the same fix with added mochitest
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> Created attachment 541663 [details] [diff] [review] [review]
> Simple fix with test
> 
> Thanks for report and fix. Here's the same fix with added mochitest

You don't need a mochitest. I was planning to attach Jesse's testcase as a crashtest.
(Assignee)

Comment 5

6 years ago
(In reply to comment #4)
> You don't need a mochitest. I was planning to attach Jesse's testcase as a
> crashtest.

By attach I mean push.
(Reporter)

Comment 6

6 years ago
OTOH, maybe it's good to have it as a mochitest for the

  ok(frameWin.performance==null, 'Performance for non-existing frame???');

Updated

6 years ago
Attachment #541644 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 7

6 years ago
Pushed to mozilla-inbound with the crashtest.

Igor, can you write a patch that adds the test mentioned in comment 6 to the current performance test suite?
Flags: in-testsuite+
Whiteboard: [inbound]
(Assignee)

Comment 8

6 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/070f95edc105
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7

Comment 9

6 years ago
Created attachment 542113 [details] [diff] [review]
Mochitest only

I had this test as part of the previous patch. There is not much of test suite yet, and the existing test covers basic scenario, so mixing this test in doesn't feel right to me.
Attachment #541663 - Attachment is obsolete: true

Comment 10

6 years ago
Verified fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I loaded the test case from the description on the above builds and none of them crashed. There were no other issues either.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.