666999 - nsSSLThread::stoppedOrStopping returns wrong value when it does not have a reference to the SSL thread

Status: RESOLVED WONTFIX

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #468736 +++

The code is:

PRBool nsSSLThread::stoppedOrStopping()
{
  if (!ssl_thread_singleton)
    return PR_FALSE;

  return ssl_thread_singleton->exitRequestedNoLock();
}

and it should be:

PRBool nsSSLThread::stoppedOrStopping()
{
  if (!ssl_thread_singleton)
    return PR_TRUE;

  return ssl_thread_singleton->exitRequestedNoLock();
}

Comment 1

[Landry Breuil (:gaston)]

Fwiw i've tried this change and it doesn't fix bug #669050

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

nsSSLThread is no longer a thing after the patches for bug 674147 landed.