Closed
Bug 667010
Opened 14 years ago
Closed 14 years ago
"ASSERTION: unexpected block frame" with text-overflow: ellipsis, <fieldset>
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: jruderman, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: assertion, regression, testcase, Whiteboard: [inbound])
Attachments
(4 files, 2 obsolete files)
No description provided.
|
Reporter | |
Comment 1•14 years ago
|
||
|
|
Reporter | |
Comment 2•14 years ago
|
||
###!!! ASSERTION: unexpected block frame: '!aFrame->GetStyleDisplay()->IsBlockOutside()', file layout/generic/TextOverflow.cpp, line 88
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → matspal
OS: Mac OS X → All
Hardware: x86 → All
|
|
Assignee | |
Comment 3•14 years ago
|
||
When text-overflow style on BODY we shouldn't traverse this frame,
so I guess we need to check for blocks after all...
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #541775 -
Flags: review?(roc)
|
|
Assignee | |
Comment 5•14 years ago
|
||
Hang on, so the line containing the fieldset returns true for IsInline(), but the fieldset returns true for IsBlockOutside? That seems ... wrong.
I see, the fieldset is display:inline, but its anonymous block child is returning true for IsBlockOutside.
I think we should make IsAtomicElement return true for an inline fieldset. I think probably instead of checking mDisplay != NS_STYLE_DISPLAY_INLINE, we should check whether the frame is a subclass of nsInlineFrame.
|
||
Comment 8•14 years ago
|
||
Would it make sense to check it for being a line participant?
Yes!
|
|
Assignee | |
Comment 10•14 years ago
|
||
Also fixed an unrelated bug: when a line has overflow (say from a float)
but no inline overflow we shouldn't create a marker... this works fine,
except if there's a placeholder frame outside the block content rect
it would count as overflow and trigger a marker.
(regression from starting to include zero-sized frames in the analysis)
Attachment #541775 -
Attachment is obsolete: true
Attachment #541777 -
Attachment is obsolete: true
Attachment #543682 -
Flags: review?(roc)
Attachment #541775 -
Flags: review?(roc)
Comment on attachment 543682 [details] [diff] [review]
fix + reftest, rev. 2
Review of attachment 543682 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #543682 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 12•14 years ago
|
||
Flags: in-testsuite+
Whiteboard: [inbound]
|
|
Assignee | |
Comment 13•14 years ago
|
||
I disabled the test on Android because of R1 orange. Seems to work fine on
other platforms so I'm not going to worry about it for now.
http://hg.mozilla.org/integration/mozilla-inbound/rev/c8c8aa5f9870
|
||
Comment 14•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/dfdbd34cdad4
http://hg.mozilla.org/mozilla-central/rev/c8c8aa5f9870
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•