Closed Bug 667012 Opened 11 years ago Closed 11 years ago
ensure that PKG
_PATH exists when generating checksums file
When trying to upload the xulrunner sdks, there was a problem with the x86_64 sdk not being able to upload because the PKG_PATH directory didn't exist. I am not sure why this directory didn't get created. We could do mkdir -p $(DIST)/$(PKG_PATH) as the first step of the checksum: target, but I don't know if that is the desired course of action.
Attachment #541753 - Flags: review?(khuey)
I did the gust of this in bug 666953 manually and everything worked.
(In reply to comment #1) > I did the gust of this in bug 666953 manually and everything worked. guts. specifically bug 666953 comment 10
Attachment #541753 - Flags: review?(khuey) → review+
Assignee: nobody → jhford
Status: NEW → ASSIGNED
Attachment #541807 - Flags: checkin?
Comment on attachment 541807 [details] changeset http://hg.mozilla.org/projects/build-system/rev/74f776d61679
Attachment #541807 - Flags: checkin? → checkin+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
This needs to be merged into -aurora, -beta and -release to ensure that this doesn't bite us for releases off these trains.
There are missing parenthesis around the make variable. As a result, instead of creating the PKG_PATH directory, we are creating a directory called "HECKSUM_FILE"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 542612 [details] [diff] [review] fix typo bah, should have caught that.
Attachment #542612 - Flags: review?(khuey) → review+
This is a combined patch intended for branch landing.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Can we land this on mozilla-beta? It's breaking 6.0 beta xulrunner builds there, and will break 6.0 final as well.
Comment on attachment 542830 [details] [diff] [review] combined patch for branches Yeah ... not sure why this wasn't nommed.
Attachment #542830 - Flags: approval-mozilla-beta?
Attachment #542830 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to comment #13) > Comment on attachment 542830 [details] [diff] [review] [review] > combined patch for branches > > Yeah ... not sure why this wasn't nommed. I see this nom'd for beta. Should this also be nom'd for aurora?
This is in Aurora, because it made the cutoff.
qa- as no QA fix verification needed
You need to log in before you can comment on or make changes to this bug.