Note: There are a few cases of duplicates in user autocompletion which are being worked on.

ensure that PKG_PATH exists when generating checksums file

RESOLVED FIXED in Firefox 6

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jhford, Assigned: jhford)

Tracking

unspecified
mozilla6
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox6 fixed, firefox7 fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments, 2 obsolete attachments)

Created attachment 541753 [details] [diff] [review]
ensure that PKG_PATH exists

When trying to upload the xulrunner sdks, there was a problem with the x86_64 sdk not being able to upload because the PKG_PATH directory didn't exist.  I am not sure why this directory didn't get created.

We could do mkdir -p $(DIST)/$(PKG_PATH) as the first step of the checksum: target, but I don't know if that is the desired course of action.
Attachment #541753 - Flags: review?(khuey)
I did the gust of this in bug 666953 manually and everything worked.
(In reply to comment #1)
> I did the gust of this in bug 666953 manually and everything worked.

guts.

specifically bug 666953 comment 10
Attachment #541753 - Flags: review?(khuey) → review+
Created attachment 541807 [details]
changeset
Assignee: nobody → jhford
Status: NEW → ASSIGNED
Attachment #541807 - Flags: checkin?
Comment on attachment 541807 [details]
changeset

http://hg.mozilla.org/projects/build-system/rev/74f776d61679
Attachment #541807 - Flags: checkin? → checkin+
http://hg.mozilla.org/mozilla-central/rev/74f776d61679
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
This needs to be merged into -aurora, -beta and -release to ensure that this doesn't bite us for releases off these trains.
tracking-firefox5: --- → ?
tracking-firefox6: --- → ?
tracking-firefox5: ? → ---
tracking-firefox6: ? → ---
There are missing parenthesis around the make variable.  As a result, instead of creating the PKG_PATH directory, we are creating a directory called "HECKSUM_FILE"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 542612 [details] [diff] [review]
fix typo
Attachment #541753 - Attachment is obsolete: true
Attachment #541807 - Attachment is obsolete: true
Attachment #542612 - Flags: review?(khuey)
Comment on attachment 542612 [details] [diff] [review]
fix typo

bah, should have caught that.
Attachment #542612 - Flags: review?(khuey) → review+
Created attachment 542830 [details] [diff] [review]
combined patch for branches

This is a combined patch intended for branch landing.
http://hg.mozilla.org/mozilla-central/rev/545d773cc96a
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Can we land this on mozilla-beta? It's breaking 6.0 beta xulrunner builds there, and will break 6.0 final as well.
Comment on attachment 542830 [details] [diff] [review]
combined patch for branches

Yeah ... not sure why this wasn't nommed.
Attachment #542830 - Flags: approval-mozilla-beta?

Updated

6 years ago
Attachment #542830 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to comment #13)
> Comment on attachment 542830 [details] [diff] [review] [review]
> combined patch for branches
> 
> Yeah ... not sure why this wasn't nommed.

I see this nom'd for beta. Should this also be nom'd for aurora?
This is in Aurora, because it made the cutoff.
http://hg.mozilla.org/releases/mozilla-beta/rev/2147a77f9e45
status-firefox6: --- → fixed
status-firefox7: --- → fixed
Target Milestone: mozilla7 → mozilla6
qa- as no QA fix verification needed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.