Closed Bug 667012 Opened 14 years ago Closed 14 years ago

ensure that PKG_PATH exists when generating checksums file

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox6 fixed, firefox7 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla6
Tracking Flags:
Tracking Status
firefox6 --- fixed
firefox7 --- fixed

People

(Reporter: jhford, Assigned: jhford)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files, 2 obsolete files)

fix typo
500 bytes, patch
khuey
: review+
Details | Diff | Splinter Review
combined patch for branches
725 bytes, patch
asa
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached patch ensure that PKG_PATH exists (obsolete) — — Splinter Review
When trying to upload the xulrunner sdks, there was a problem with the x86_64 sdk not being able to upload because the PKG_PATH directory didn't exist. I am not sure why this directory didn't get created. We could do mkdir -p $(DIST)/$(PKG_PATH) as the first step of the checksum: target, but I don't know if that is the desired course of action.
Attachment #541753 - Flags: review?(khuey)
I did the gust of this in bug 666953 manually and everything worked.
(In reply to comment #1) > I did the gust of this in bug 666953 manually and everything worked. guts. specifically bug 666953 comment 10
Attached file changeset (obsolete) —
Assignee: nobody → jhford
Status: NEW → ASSIGNED
Attachment #541807 - Flags: checkin?
http://hg.mozilla.org/mozilla-central/rev/74f776d61679
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
This needs to be merged into -aurora, -beta and -release to ensure that this doesn't bite us for releases off these trains.
tracking-firefox5: --- → ?
tracking-firefox6: --- → ?
There are missing parenthesis around the make variable. As a result, instead of creating the PKG_PATH directory, we are creating a directory called "HECKSUM_FILE"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch fix typo — — Splinter Review
Attachment #541753 - Attachment is obsolete: true
Attachment #541807 - Attachment is obsolete: true
Attachment #542612 - Flags: review?(khuey)
Comment on attachment 542612 [details] [diff] [review] fix typo bah, should have caught that.
Attachment #542612 - Flags: review?(khuey) → review+
This is a combined patch intended for branch landing.
http://hg.mozilla.org/mozilla-central/rev/545d773cc96a
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Can we land this on mozilla-beta? It's breaking 6.0 beta xulrunner builds there, and will break 6.0 final as well.
Comment on attachment 542830 [details] [diff] [review] combined patch for branches Yeah ... not sure why this wasn't nommed.
Attachment #542830 - Flags: approval-mozilla-beta?
Attachment #542830 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to comment #13) > Comment on attachment 542830 [details] [diff] [review] [review] > combined patch for branches > > Yeah ... not sure why this wasn't nommed. I see this nom'd for beta. Should this also be nom'd for aurora?
This is in Aurora, because it made the cutoff.
qa- as no QA fix verification needed
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: