667202 - Provide 'ss' centrally for all browser-chrome sessionstore tests

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 541935 [details] [diff] [review]
patch

I was going to go the opposite direction with bug 664325, but this works too. Make ss a const and we're good.

Comment 3

[Dão Gottwald [:dao]]

It's intentionally not a const, so that the scope can be cleared after each test.

Comment 4

[John P Baker]

Comment on attachment 541935 [details] [diff] [review]
patch

>diff --git a/browser/components/sessionstore/test/browser/browser_350525.js b/browser/components/sessionstore/test/browser/browser_350525.js
>--- a/browser/components/sessionstore/test/browser/browser_350525.js
>+++ b/browser/components/sessionstore/test/browser/browser_350525.js
>@@ -3,29 +3,19 @@ function test() {
>   
>   function test(aLambda) {
>     try {
>       return aLambda() || true;
>     }
>     catch (ex) { }
>     return false;
>   }
>-  
>-  // test setup
>-  let tabbrowser = gBrowser;
>+
>   waitForExplicitFinish();
>-  
>-  // component
>-  let ssComponent = test(function() Cc["@mozilla.org/browser/sessionstore;1"]);
>-  ok(ssComponent, "reference the sessionstore component");
>-  
>-  // service
>-  let ss = test(function() ssComponent.getService(Ci.nsISessionStore));
>-  ok(ss, "reference the sessionstore service");
>-  
>+

This one looks odd to me as the test _was_ the check of references to the component and service.

Comment 5

[Dão Gottwald [:dao]]

The check was pointless. No sessionstore test would pass if the service wasn't available.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e62b80fd8cb6

Comment 7

[AndreiD[QA]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a2) Gecko/20110706 Firefox/7.0a2
Verified fixed - detailed by the changest in comment 6.