User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110625 Firefox/7.0a1 Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110625 Firefox/7.0a1 The latest hourly azure builds are having problem with specifically this IE test : Psychedelic Browsing ( http://ie.microsoft.com/testdrive/performance/psychedelicbrowsing/Default.html ) Reproducible: Always Steps to Reproduce: 1.Have the latest Hourly (at point of bug posting) having the Azure Rendering engine ( http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1309018896/ ) 2.Open link ie.microsoft.com/testdrive/performance/psychedelicbrowsing/Default.html 3.Start the Psychedelic Browsing test by clicking Find Out Actual Results: Firefox Crashes Expected Results: The test should run properly as it runs on latest Nightly (7.0a1 (2011-06-25))
Crash on mozilla-inbound nightly: Crash Report [@ _invalid_parameter_noinfo ] Crash Id bp-a88dc130-2960-4259-9658-5a09e2110625 bp-be57e6f6-dccc-4c20-9b0c-eb6f42110625
If Alice sees it, this is confirmed. :)
Could you add this a dependency of bug 651858?
Confirmed on latest m-c hourly build https://crash-stats.mozilla.com/report/index/bp-d8ccec74-293d-45c6-9ed0-24f5b2110625
Created attachment 541992 [details] [diff] [review] Silently ignore drawing glyph runs where no glyphs are to be drawn This demo draws fill text call where the textrun reports no glyphs to be drawn. In this situation we should ignore the draw call and go on drawing rather than invalidly use the vector and cause a crash. The exact cause as to why the textrun reports no glyphs to be drawn should be examined further.
Created attachment 541993 [details] [diff] [review] Silently ignore drawing glyph runs where no glyphs are to be drawn v2 I was unable to create this situation but we probably should just continue to draw any runs in the textrun that -do- draw valid glyphs. I've adjusted the patch for this.
Just to be clear, the same situation exists in traditional glyph drawing but it's silently ignored there as well, at gfxFont.cpp:1185. glyphCount there is found to be 0 similarly as for Azure canvas.
Please push this to inbound as early as possible. There might be several other places where a similar crash can occur once today's Nightly is out
This is pending review, once reviewed it will be pushed. I'm not sure what causes the condition, once we've figured out we should probably add a test for it. Until then I doubt this is a common situation but I'll keep an eye out.
Comment on attachment 541993 [details] [diff] [review] Silently ignore drawing glyph runs where no glyphs are to be drawn v2 Make sure you add a test case before pushing this.
Created attachment 542033 [details] [diff] [review] Add a testcase for the bug This adds a crashtest for this bug, it seems to occur when trying to draw 0-sized fonts.
Comment on attachment 542033 [details] [diff] [review] Add a testcase for the bug Drop the xmlns stuff and give the test a better name like 0px-size-font-667225.html
Merged: http://hg.mozilla.org/mozilla-central/rev/9a79edc67610 http://hg.mozilla.org/mozilla-central/rev/59374caa391e
Did It miss today's Nightly ? I am not seeing it under the Nightly Changeset http://hg.mozilla.org/mozilla-central/rev/5e072732cb45
It did miss today's nightly.
The issue is not reproducible anymore. Verified fixed on: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a2) Gecko/20110706 Firefox/7.0a2 Mozilla/5.0 (X11; Linux i686; rv:7.0a2) Gecko/20110706 Firefox/7.0a2 Mozilla/5.0 (Windows NT 6.1; rv:7.0a2) Gecko/20110706 Firefox/7.0a2 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a2) Gecko/20110706 Firefox/7.0a2