Closed Bug 667385 Opened 9 years ago Closed 8 years ago

nshttppipeline::isdone wrong

Categories

(Core :: Networking: HTTP, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

Attachments

(1 file)

pipeline defines isdone() as when the req and resp q is empty.. but it is really when the req and resp q's contain only nshttptransactions which are isDone()..
Attached patch v1Splinter Review
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #542095 - Flags: review?(honzab.moz)
Comment on attachment 542095 [details] [diff] [review]
v1

Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab
Attachment #542095 - Flags: review?(honzab.moz) → review+
Comment on attachment 542095 [details] [diff] [review]
v1

Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------

sr=honzab with please do a followup commit:
- change PRBool to bool / PR_TRUE to true

Up to you:
- i++ -> ++i
- check for result of call to Response()/Request(), but that would mean something really broken that would show up in other places of the code first, so it is OK
Attachment #542095 - Flags: superreview+
https://hg.mozilla.org/mozilla-central/rev/97334042d500
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.