The default bug view has changed. See this FAQ.

nshttppipeline::isdone wrong

RESOLVED FIXED in mozilla11

Status

()

Core
Networking: HTTP
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

unspecified
mozilla11
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
pipeline defines isdone() as when the req and resp q is empty.. but it is really when the req and resp q's contain only nshttptransactions which are isDone()..
(Assignee)

Comment 1

6 years ago
Created attachment 542095 [details] [diff] [review]
v1
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #542095 - Flags: review?(honzab.moz)
Comment on attachment 542095 [details] [diff] [review]
v1

Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab
Attachment #542095 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/639b9381a808
Target Milestone: --- → mozilla11
Comment on attachment 542095 [details] [diff] [review]
v1

Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------

sr=honzab with please do a followup commit:
- change PRBool to bool / PR_TRUE to true

Up to you:
- i++ -> ++i
- check for result of call to Response()/Request(), but that would mean something really broken that would show up in other places of the code first, so it is OK
Attachment #542095 - Flags: superreview+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/97334042d500
https://hg.mozilla.org/mozilla-central/rev/97334042d500
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
And the main landing:
https://hg.mozilla.org/mozilla-central/rev/639b9381a808
You need to log in before you can comment on or make changes to this bug.