Closed
Bug 667385
Opened 14 years ago
Closed 14 years ago
nshttppipeline::isdone wrong
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mcmanus, Assigned: mcmanus)
Details
Attachments
(1 file)
|
963 bytes,
patch
|
mayhemer
:
review+
mayhemer
:
superreview+
|
Details | Diff | Splinter Review |
pipeline defines isdone() as when the req and resp q is empty.. but it is really when the req and resp q's contain only nshttptransactions which are isDone()..
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Comment 2•14 years ago
|
||
Comment on attachment 542095 [details] [diff] [review]
v1
Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------
r=honzab
Attachment #542095 -
Flags: review?(honzab.moz) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Target Milestone: --- → mozilla11
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 542095 [details] [diff] [review]
v1
Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------
sr=honzab with please do a followup commit:
- change PRBool to bool / PR_TRUE to true
Up to you:
- i++ -> ++i
- check for result of call to Response()/Request(), but that would mean something really broken that would show up in other places of the code first, so it is OK
Attachment #542095 -
Flags: superreview+
|
|
Assignee | |
Comment 5•14 years ago
|
||
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•14 years ago
|
||
And the main landing:
https://hg.mozilla.org/mozilla-central/rev/639b9381a808
You need to log in
before you can comment on or make changes to this bug.
Description
•