Last Comment Bug 667385 - nshttppipeline::isdone wrong
: nshttppipeline::isdone wrong
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Patrick McManus [:mcmanus]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-26 22:23 PDT by Patrick McManus [:mcmanus]
Modified: 2012-02-01 13:56 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (963 bytes, patch)
2011-06-26 22:26 PDT, Patrick McManus [:mcmanus]
honzab.moz: review+
honzab.moz: superreview+
Details | Diff | Splinter Review

Description Patrick McManus [:mcmanus] 2011-06-26 22:23:28 PDT
pipeline defines isdone() as when the req and resp q is empty.. but it is really when the req and resp q's contain only nshttptransactions which are isDone()..
Comment 1 Patrick McManus [:mcmanus] 2011-06-26 22:26:14 PDT
Created attachment 542095 [details] [diff] [review]
v1
Comment 2 Honza Bambas (:mayhemer) 2011-07-11 10:45:42 PDT
Comment on attachment 542095 [details] [diff] [review]
v1

Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab
Comment 3 Patrick McManus [:mcmanus] 2011-11-15 07:18:26 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/639b9381a808
Comment 4 Honza Bambas (:mayhemer) 2011-11-15 08:09:01 PST
Comment on attachment 542095 [details] [diff] [review]
v1

Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------

sr=honzab with please do a followup commit:
- change PRBool to bool / PR_TRUE to true

Up to you:
- i++ -> ++i
- check for result of call to Response()/Request(), but that would mean something really broken that would show up in other places of the code first, so it is OK
Comment 5 Patrick McManus [:mcmanus] 2011-11-15 08:30:37 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/97334042d500
Comment 6 Ed Morley [:emorley] 2011-11-15 11:45:04 PST
https://hg.mozilla.org/mozilla-central/rev/97334042d500
Comment 7 Ed Morley [:emorley] 2011-11-15 11:46:24 PST
And the main landing:
https://hg.mozilla.org/mozilla-central/rev/639b9381a808

Note You need to log in before you can comment on or make changes to this bug.