EventSource should use the same nsIContentPolicy type as XHR

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Or add some new type for eventsource
Blocks: 338583
(Assignee)

Comment 2

6 years ago
Created attachment 542793 [details] [diff] [review]
patch

This is what was discussed during security review.
Assignee: nobody → Olli.Pettay
Attachment #542793 - Flags: review?(dveditz)
(Assignee)

Comment 3

6 years ago
We could also just add a new type for eventsource.
I don't know which one is better.
EventSource works in many ways like multipart XHR.
Comment on attachment 542793 [details] [diff] [review]
patch

r=dveditz

What type is websockets using? Should probably be the same. "XHR" == "script initiated data connection"? Could even add

  const unsigned long TYPE_DATAREQUEST = 11;

to the IDL as an alias. Don't remove the existing one though: it's used by several add-ons.
Attachment #542793 - Flags: review?(dveditz) → review+
Blocks: 692067
(Assignee)

Comment 5

6 years ago
Created attachment 570668 [details] [diff] [review]
updated
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/5c971924966e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Component: DOM: Other → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.