667490 - EventSource should use the same nsIContentPolicy type as XHR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Or add some new type for eventsource

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This is what was discussed during security review.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

We could also just add a new type for eventsource.
I don't know which one is better.
EventSource works in many ways like multipart XHR.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 542793 [details] [diff] [review]
patch

r=dveditz

What type is websockets using? Should probably be the same. "XHR" == "script initiated data connection"? Could even add

  const unsigned long TYPE_DATAREQUEST = 11;

to the IDL as an alias. Don't remove the existing one though: it's used by several add-ons.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: updated

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/5c971924966e