Last Comment Bug 667490 - EventSource should use the same nsIContentPolicy type as XHR
: EventSource should use the same nsIContentPolicy type as XHR
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks: 338583 692067
  Show dependency treegraph
 
Reported: 2011-06-27 09:34 PDT by Olli Pettay [:smaug]
Modified: 2013-04-04 13:52 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.70 KB, patch)
2011-06-29 06:12 PDT, Olli Pettay [:smaug]
dveditz: review+
Details | Diff | Review
updated (2.81 KB, patch)
2011-10-31 05:49 PDT, Olli Pettay [:smaug]
no flags Details | Diff | Review

Description Olli Pettay [:smaug] 2011-06-27 09:34:30 PDT

    
Comment 1 Olli Pettay [:smaug] 2011-06-27 09:38:01 PDT
Or add some new type for eventsource
Comment 2 Olli Pettay [:smaug] 2011-06-29 06:12:13 PDT
Created attachment 542793 [details] [diff] [review]
patch

This is what was discussed during security review.
Comment 3 Olli Pettay [:smaug] 2011-06-29 06:13:49 PDT
We could also just add a new type for eventsource.
I don't know which one is better.
EventSource works in many ways like multipart XHR.
Comment 4 Daniel Veditz [:dveditz] 2011-08-22 11:20:06 PDT
Comment on attachment 542793 [details] [diff] [review]
patch

r=dveditz

What type is websockets using? Should probably be the same. "XHR" == "script initiated data connection"? Could even add

  const unsigned long TYPE_DATAREQUEST = 11;

to the IDL as an alias. Don't remove the existing one though: it's used by several add-ons.
Comment 5 Olli Pettay [:smaug] 2011-10-31 05:49:42 PDT
Created attachment 570668 [details] [diff] [review]
updated
Comment 6 Olli Pettay [:smaug] 2011-10-31 06:31:55 PDT
https://hg.mozilla.org/mozilla-central/rev/5c971924966e

Note You need to log in before you can comment on or make changes to this bug.