667533 - Display application/json data as text

Status: RESOLVED FIXED

(Core :: General, enhancement)

Description

[Liam Morland]

When loading a URL with MIME type application/json, Firefox should display it as plain text instead of offering to download the file.

Reproducible: Always

Steps to Reproduce:
Load a URL containing JSON data served with application/json MIME type.
Actual Results:  
Firefox offers to download the file.

Expected Results:  
Firefox displays the JSON as plain text.

A patch to fix this in in bug #606488

Comment 1

[Markus Stange [:mstange]]

Attachment: v1

This is the same patch as in bug 606488, but also contains a test. I'm only requesting review on the test. I'm not sure that I'm not making any wrong assumptions there. For example, is it safe to assume that plain text documents have a document and a body?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 549818 [details] [diff] [review]
v1

Yeah, it's safe to assume that.  The web depends on it, and the HTML5 spec requires that behavior.

Comment 3

[Markus Stange [:mstange]]

Attachment: with commit msg

Comment 4

[Markus Stange [:mstange]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/10c2c74197fc

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/10c2c74197fc

Comment 6

[[e-mail]]

Is there some central way of detecting whether a MIME type is text based rather than patching all over the place (e.g. bug 882995 was recently filed to "catch up")?

My best idea is to look at the document - if it's a MediaDocument then you probably don't want to allow View Source on it, while if it's XUL or SVG then you probably don't want to FAYT either.