667555 - Cannot right click on <button> input in Firefox 4

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter]

User Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.18) Gecko/20110614 Firefox/3.6.18 ( .NET CLR 3.5.30729; .NET4.0E)
Build ID: 20110614230723

Steps to reproduce:

Right click on the following does nothing, to mimic "open in tab" you must use the ctrl key and click on it.  <a href="xxxx.php" style="text-decoration:none;" target="_blank"><button class="button grey" type="submit">Test</button></a>




Actual results:

Nothing happens when you right click on a "button"


Expected results:

It should bring up the typical right click options.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Is this the expected behavior?

Comment 2

[Peter]

The expected behavior is that of FF 3.6, Chrome, IE and every other browser, if you right click on a link you get a menu of options.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Also, a minimal testcase attached using "Add an attachment" would be great.

Comment 4

[Peter]

That is almost a trick question, in FF 4 nothing happens, nothing to show in a screen shot, if you right click on a <button> encasalated in an <href> tag nothing will happen.  However, attached to this bug is a screenshot of what happens in 3.6.18.

Comment 5

[Peter]

Attachment: screen shot of 3.6.18.

This is a screen shot from 3.6.18, right clicking in FF4 does not bring up such a menu.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

A testcase, please ;)

Comment 7

[Peter]

Attachment: test HTML file

Comment 8

[Peter]

Attachment: Test Cases

Comment 9

[AndreiD[QA]]

I could reproduce the issue on the latest Nightly:
Mozilla/5.0 (Windows NT 6.1; rv:7.0a1) Gecko/20110627 Firefox/7.0a1

Bug could be set on new if not a dupe.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: a bit modified test

The problem is that what the context menu should show.
In this case Fx, correctly, activates only the form. Chrome seems to
activate *both* form and link, yet show context menu only about the link.
Opera activates only the form, yet it shows context menu only about the link.

Comment 11

[Peter]

From a users perspective the behavior of all prior Firefox versions is preferred.  It is treated as a *link* which it is.  Complicated in a form element but a common CSS button.

Comment 12

[AndreiD[QA]]

While trying to find a regression window I went back to the 3.6.18 build on which, for me the example in comment 10 reflects the issue (the inability to get a context menu on a button)

So the issue is reproducible on 
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.18) Gecko/20110614 Firefox/3.6.18, as well, which leads to the questions whether this is a bug or not.
IMO it's pointless to have a context menu on a form button, but at least something should be done about the focus that is visible after you click right on the button.

Comment 13

[Mounir Lamouri (:mounir)]

Oh, that would explain why I can't find the regression window between 3.6 and 4.0...
Unless it's working with 3.5?

Comment 14

[Peter]

Works in 3.5 and 3.6.  Worked in all versions prior to 4.

It isn't a button it is a link, CSS allows for non image buttons using the button tag wrapped in a link.  It is a link at the end of the day and all prior versions handled it as such.

Comment 15

[AndreiD[QA]]

(In reply to comment #14)
> Works in 3.5 and 3.6.  Worked in all versions prior to 4.

I still can't reproduce it on 3.5 neither on 3.6. I got these builds from ftp.mozilla.org
Peter, where did you get this build you can reproduce the issue, from? Thanks

Comment 16

[Peter]

Using 3.6.18, current version.  Always has worked.

When you say you can't reproduce you are saying you cannot get the screenshot attached when right clicking in the example HTML?

Comment 17

[Alice0775 White]

Tested with attachment 542266 [details],

Works:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.8.0.14eol) Gecko/20080308 Firefox/1.5.0.12eol
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.8.1.22pre) Gecko/20090415 BonEcho/2.0.0.22pre

Fails:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.0.19) Gecko/2010031422 Firefox/3.0.19 ID:2010031422
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.20pre) Gecko/20110607 Firefox/3.5.20pre ID:20110607030804
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e44db3a28fea
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.18) Gecko/20110614 Firefox/3.6.18 ID:20110614230723
http://hg.mozilla.org/releases/mozilla-2.0/rev/fca718600ca0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 ID:20110413222027
http://hg.mozilla.org/releases/mozilla-release/rev/7b56ff900c2a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0) Gecko/20100101 Firefox/5.0 ID:20110615151330
http://hg.mozilla.org/releases/mozilla-aurora/rev/2b38c9d8c280
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a2) Gecko/20110628 Firefox/6.0a2 ID:20110628042004
http://hg.mozilla.org/mozilla-central/rev/383e60bc9089
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110628 Firefox/7.0a1 ID:20110628030753

Comment 18

[Alice0775 White]

Works:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9b4pre) Gecko/2008022320 Firefox/3.0b4pre ID:2008022320
Fails:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9b4pre) Gecko/2008022404 Firefox/3.0b4pre ID:2008022404
Pushlog:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-23+20%3A00%3A00&maxdate=2008-02-24+05%3A00%3A00&cvsroot=%2Fcvsroot
Relevant bug:
Bug 404536 - Right click on Web page button should be ignored (don't show context menu on web form controls except textboxes)

At that time, this behavior seems to be intentional change.

However, At the present time,
The context menu pops up on Opera 11.50 , Google Chrome12.0.742.100 and IE9.
No context menu pops up on Firefox only .

Comment 19

[Peter]

Right click on Button in form should be ignored, but right click on link wrapping a button should not be ignored, that is not the correct behavior for all the CSS3 button/gradient development going on.

Comment 20

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 542428 [details]
a bit modified test

But what would you expect to get with this testcase?

Comment 21

[Alice0775 White]

It seems to be fixed by Bug 433168.
Can anybody confirm this?