Closed Bug 667643 Opened 10 years ago Closed 10 years ago

Switch suite to use Services.wm

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.4

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch switch suite to use Services.wm (obsolete) — Splinter Review
At the moment we have Services.jsm imported but we're not making full use of it.
This patch:
* Switches code in suite to make use of Services.wm
Attachment #542297 - Flags: review?(neil)
Comment on attachment 542297 [details] [diff] [review]
switch suite to use Services.wm

I don't like referring to globals from XBL, although it might be possible to make an exception for preferences, if it's only usable from the one XUL file.

The fixes in the JS files aren't a problem, of course.
Attachment #542297 - Flags: feedback?(mnyromyr)
Comment on attachment 542297 [details] [diff] [review]
switch suite to use Services.wm

(In reply to comment #1)
> I don't like referring to globals from XBL,

Yeah, agreed.
We probably could import the Services.jsm in the ctor of the prefwindow binding.
That won't do any harm and make the XBL independent of "foreign" includes.

> although it might be possible to make an exception for preferences,
> if it's only usable from the one XUL file.

Well, what about custom prefwindows, eg in addons? They would have to include the Services.jsm in their .xul, which would be ... unfortunate.
Changes since last version:
* Removed the XBL changes.
Attachment #542297 - Attachment is obsolete: true
Attachment #543228 - Flags: review?(neil)
Attachment #542297 - Flags: review?(neil)
Attachment #542297 - Flags: feedback?(mnyromyr)
Attachment #543228 - Flags: review?(neil) → review+
Comment on attachment 543228 [details] [diff] [review]
switch suite to use Services.wm without XBL [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/c319bf1f086a
Attachment #543228 - Attachment description: switch suite to use Services.wm without XBL → switch suite to use Services.wm without XBL [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.4
You need to log in before you can comment on or make changes to this bug.