667643 - Switch suite to use Services.wm

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Attachment: switch suite to use Services.wm

At the moment we have Services.jsm imported but we're not making full use of it.
This patch:
* Switches code in suite to make use of Services.wm

Comment 1

[[e-mail]]

Comment on attachment 542297 [details] [diff] [review]
switch suite to use Services.wm

I don't like referring to globals from XBL, although it might be possible to make an exception for preferences, if it's only usable from the one XUL file.

The fixes in the JS files aren't a problem, of course.

Comment 2

[Karsten Düsterloh]

Comment on attachment 542297 [details] [diff] [review]
switch suite to use Services.wm

(In reply to comment #1)
> I don't like referring to globals from XBL,

Yeah, agreed.
We probably could import the Services.jsm in the ctor of the prefwindow binding.
That won't do any harm and make the XBL independent of "foreign" includes.

> although it might be possible to make an exception for preferences,
> if it's only usable from the one XUL file.

Well, what about custom prefwindows, eg in addons? They would have to include the Services.jsm in their .xul, which would be ... unfortunate.

Comment 3

[Ian Neal]

Attachment: switch suite to use Services.wm without XBL [Checked in: Comment 4]

Changes since last version:
* Removed the XBL changes.

Comment 4

[Ian Neal]

Comment on attachment 543228 [details] [diff] [review]
switch suite to use Services.wm without XBL [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/c319bf1f086a