667653 - Make NS_FRAME_SELECTED_CONTENT on text frames less sticky so we can take the fast text painting path more often

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Mats Palmgren (inactive)]

Once the frame bit NS_FRAME_SELECTED_CONTENT is set, it's rarely unset
even after the selection has changed to not affect the text frame.
This makes us take the slower paint-with-selection path.

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

Add an early return in PaintTextWithSelectionColors when !allTypes
as I believe that means there is no selection for this frame.
Also, remove the NS_FRAME_SELECTED_CONTENT bit in a couple of places
where we know from the SelectionDetails that there is no selection,
to take the fast path until something is selected again.

(this patch applies on top of bug 666669)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 542361 [details] [diff] [review]
fix

Review of attachment 542361 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 3

[Mats Palmgren (inactive)]

Attachment: fix

Updated for the latest patch in bug 666669.  The relevant interdiff is:

< +    if (aStartDelta == 0 && aLengthDelta == 0) {
---
> +    if (aContentLength == aProvider.GetOriginalLength()) {

(to test if the selection analysis was done for all text of the frame)

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 542856 [details] [diff] [review]
fix

Review of attachment 542856 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 5

[Mats Palmgren (inactive)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4a7289ad8218

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/4a7289ad8218