667663 - gfxwindowsplatform.cpp(506) : warning C4715: 'gfxWindowsPlatform::GetScaledFontForFont' : not all control paths return a value

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

gfxwindowsplatform.cpp(506) : warning C4715: 'gfxWindowsPlatform::GetScaledFontForFont' : not all control paths return a value

Looks like it's complaining because the function only returns a value inside the if condition. This code was added in bug 651858 part 2.
http://hg.mozilla.org/mozilla-central/rev/95039cfae6a3

Bas, what should be returned if DWrite is disabled?

Comment 1

[Bas Schouten (:bas.schouten)]

If DWrite is disabled this will all break down, so NULL seems fine :).

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Out of curiosity, why use the if statement at all if the DWrite situation is the only one that can do something sane anyway?

Comment 3

[Bas Schouten (:bas.schouten)]

To minimize churn on the function as we add more azure backends.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Patch

Comment 5

[Bas Schouten (:bas.schouten)]

Comment on attachment 542332 [details] [diff] [review]
Patch

Review of attachment 542332 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/93ad15ba19d5

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/93ad15ba19d5

Comment 8

[AndreiD[QA]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a2) Gecko/20110706 Firefox/7.0a2
Verified fixed - detailed by the changeset in comment 7