667725 - Add setting dom.ipc.plugins.enabled.x86_64=false to mochitest-ipcplugins so it actually does something on 10.6

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: fix

Trying for just enough background, since I learned too much for bug 662211, and want to tell it all:

mochitest-ipcplugins started life as "run the plugin tests with the pref for out-of-process plugins turned on." Then we turned them on by default almost everywhere, and switched mochitets-ipcplugins to being "run the plugin tests with the pref for out-of-process plugins turned off."

But because they don't, and probably never will, work on OS X 10.5, and because building universal builds requires that we have two separate prefs that are both included in both halves of the build, we use dom.ipc.plugins.enabled.x86_64 to enable them on 10.6, and dom.ipc.plugins.enabled.i386 to disable them on 10.5 (and dom.ipc.plugins.enabled.ppc to pretend we still care about PPC).

Right now, mochitest-ipcplugins passes "--setpref=dom.ipc.plugins.enabled=false" which turns them off on Linux and Windows, but leaves us using the default value of the x86_64/i386 prefs on OS X, so on 10.6 we run with out-of-process twice, in both regular mochitests and mochitest-ipcplugins, and on 10.5 we run with in-process twice.

The thing to do for 10.5 would be to just stop running mochitest-ipcplugins at all, but I'll leave that for someone who has some idea where in buildbot-configs to even start. The thing to do for 10.6 is to just also set the pref that is only read there, dom.ipc.plugins.enabled.x86_64, so that it will run in-process like Linux and Windows already do. Bug 662211 might someday make it so that OS X falls back to reading the default pref if the arch-specific one isn't set, but any which way doing this won't hurt: either it reads the x86_64 one, or it doesn't and reads the other one.

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 542336 [details] [diff] [review]
fix

Feel free to land this on the default branch of buildbotcustom, we can pick it up in our next merge.

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 542336 [details] [diff] [review]
fix

http://hg.mozilla.org/build/buildbotcustom/rev/4b26e69083a1

Comment 3

[Phil Ringnalda (:philor)]

python mochitest/runtests.py --appname=./NightlyDebug.app/Contents/MacOS/firefox-bin --utility-path=bin --extra-profile-file=bin/plugins --certificate-path=certs --autorun --close-when-done --console-level=INFO --symbols-path=symbols --setpref=dom.ipc.plugins.enabled=false --setpref=dom.ipc.plugins.enabled.x86_64=false --ipcplugins
...
2 INFO TEST-PASS | /tests/dom/plugins/test/test_GCrace.html | Skipping this test when test plugin is not OOP.