Tests more nsHTMLInputElement attributes reflection

VERIFIED FIXED in mozilla7

Status

()

Core
DOM: Core & HTML
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 542413 [details] [diff] [review]
Patch v1
Attachment #542413 - Flags: review?(Ms2ger)
(Assignee)

Updated

6 years ago
Blocks: 586786
Comment on attachment 542413 [details] [diff] [review]
Patch v1

--- a/content/html/content/test/forms/test_input_attributes_reflection.html
+++ b/content/html/content/test/forms/test_input_attributes_reflection.html
+// TODO: maybe make those reflections be tested against all input types.

Please do :)

+// .placeholder
+reflectString(document.createElement("input"), "placeholder",
+              [ "foo\nbar", "foo\rbar" ]);

Test CRLF too?

-                           "datetime-local", "number", "range", "color" ]);
+                           "datetime-local", "number", "range", "color" ])

Intentional change?

--- a/content/html/content/test/forms/test_pattern_attribute.html
+++ b/content/html/content/test/forms/test_pattern_attribute.html
-  ok('pattern' in element, "Element should have the pattern attribute");

Might want to copy this to reflect.js, and add is(typeof aElement[aAttr], "string"), too?

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
+  stringsToTest = stringsToTest.concat(otherValues);

And this would become otherValues.forEach(function(v) { stringsToTest.push([v, v]) });
 
r=me
Attachment #542413 - Flags: review?(Ms2ger) → review+
(Assignee)

Updated

6 years ago
Depends on: 668166
(Assignee)

Updated

6 years ago
No longer depends on: 667856
(Assignee)

Comment 2

6 years ago
Created attachment 542755 [details] [diff] [review]
Patch v1.1

With comments applied.
Attachment #542413 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/7a4a281fc7a9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7

Comment 4

6 years ago
Ran the tests referred in the link from the above comment on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

+ Aurora (Fx 8.0a2) & Central (Fx 9.0a1)

All the tests have passed on all the builds.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.