667864 - Tests more nsHTMLInputElement attributes reflection

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 542413 [details] [diff] [review]
Patch v1

--- a/content/html/content/test/forms/test_input_attributes_reflection.html
+++ b/content/html/content/test/forms/test_input_attributes_reflection.html
+// TODO: maybe make those reflections be tested against all input types.

Please do :)

+// .placeholder
+reflectString(document.createElement("input"), "placeholder",
+              [ "foo\nbar", "foo\rbar" ]);

Test CRLF too?

-                           "datetime-local", "number", "range", "color" ]);
+                           "datetime-local", "number", "range", "color" ])

Intentional change?

--- a/content/html/content/test/forms/test_pattern_attribute.html
+++ b/content/html/content/test/forms/test_pattern_attribute.html
-  ok('pattern' in element, "Element should have the pattern attribute");

Might want to copy this to reflect.js, and add is(typeof aElement[aAttr], "string"), too?

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
+  stringsToTest = stringsToTest.concat(otherValues);

And this would become otherValues.forEach(function(v) { stringsToTest.push([v, v]) });
 
r=me

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1.1

With comments applied.

Comment 3

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/7a4a281fc7a9

Comment 4

[Ioana (away)]

Ran the tests referred in the link from the above comment on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

+ Aurora (Fx 8.0a2) & Central (Fx 9.0a1)

All the tests have passed on all the builds.