667962 - jemalloc in 2010 doesn't work on gmake

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[[e-mail]]

Attachment: Possible patch

My mozillabuild gmake doesn't seem to mind this Makefile, but the double-colon rules force it to rebuild everything each time, which doesn't help. I stopped libs from depending on $(DIST)/lib because we don't do that anywhere else.

Comment 2

[[e-mail]]

Pushed changeset 370bcc140023 to mozilla-central.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Backed out:

http://hg.mozilla.org/mozilla-central/rev/a627b24e684e

Comment 4

[Mike Pesce (:By-Tor)]

Changeset http://hg.mozilla.org/mozilla-central/rev/4df55cccaff4 still crashes under vs2010.

Comment 5

[[e-mail]]

Which make are you using? It works for me with 3.81.90

Comment 6

[Mike Pesce (:By-Tor)]

(In reply to comment #5)
> Which make are you using? It works for me with 3.81.90

Using pymake this time.

Comment 7

[Mike Pesce (:By-Tor)]

I hadn't had a chance to retry this patch with gmake until now.  It still crashes at the same point:

Generate a DSA key pair ...
Library File: d:/build/mozilla-central/objdir-ff-release/dist/lib/softokn3.dll 1
44384 bytes
Check File: d:/build/mozilla-central/objdir-ff-release/dist/lib/softokn3.chk
  hash: 20 bytes
    30 d7 c1 39 d9 19 a6 0e 6f 0f
    07 37 c7 b1 03 a1 4f a1 c9 04
  signature: 40 bytes
    bc 61 0c 00 44 6e cf ac f5 6d
    27 30 1c 1b be 43 04 b2 d1 ce
    5e 36 61 99 ce 92 91 b1 f6 30
    8c 1d b1 af d3 7b 38 3e e6 35
make[6]: *** [d:/build/mozilla-central/objdir-ff-release/dist/lib/softokn3.chk]
Error 5
make[6]: Leaving directory `/d/build/mozilla-central/security/nss/cmd/shlibsign'

make[5]: *** [libs] Error 2

Comment 8

[ABE Hiroki (:hATrayflood)]

maybe https://bugzilla.mozilla.org/show_bug.cgi?id=673197#c5

Comment 9

[[e-mail]]

I thought that this bug was about the build failing with gmake in a different way to pymake. If the build fails in the same way with both gmake and pymake then this bug is fixed, and any remaining issues are down to bug 674972.

Comment 10

[Mike Pesce (:By-Tor)]

Everything appears to work as it should now.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Can we close this?

Comment 12

[Mike Pesce (:By-Tor)]

I have no problems with closing this.  Any other problem would be a separate bug at this point.