jemalloc in 2010 doesn't work on gmake

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: neil@parkwaycc.co.uk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Summary: jemalloc in 2010 only works on gmake → jemalloc in 2010 doesn't work on gmake
(Assignee)

Comment 1

6 years ago
Created attachment 547970 [details] [diff] [review]
Possible patch

My mozillabuild gmake doesn't seem to mind this Makefile, but the double-colon rules force it to rebuild everything each time, which doesn't help. I stopped libs from depending on $(DIST)/lib because we don't do that anywhere else.
Attachment #547970 - Flags: review?(khuey)
Attachment #547970 - Flags: review?(khuey) → review+
Assignee: khuey → neil
(Assignee)

Comment 2

6 years ago
Pushed changeset 370bcc140023 to mozilla-central.
Backed out:

http://hg.mozilla.org/mozilla-central/rev/a627b24e684e

Comment 4

6 years ago
Changeset http://hg.mozilla.org/mozilla-central/rev/4df55cccaff4 still crashes under vs2010.
(Assignee)

Comment 5

6 years ago
Which make are you using? It works for me with 3.81.90

Comment 6

6 years ago
(In reply to comment #5)
> Which make are you using? It works for me with 3.81.90

Using pymake this time.

Comment 7

6 years ago
I hadn't had a chance to retry this patch with gmake until now.  It still crashes at the same point:

Generate a DSA key pair ...
Library File: d:/build/mozilla-central/objdir-ff-release/dist/lib/softokn3.dll 1
44384 bytes
Check File: d:/build/mozilla-central/objdir-ff-release/dist/lib/softokn3.chk
  hash: 20 bytes
    30 d7 c1 39 d9 19 a6 0e 6f 0f
    07 37 c7 b1 03 a1 4f a1 c9 04
  signature: 40 bytes
    bc 61 0c 00 44 6e cf ac f5 6d
    27 30 1c 1b be 43 04 b2 d1 ce
    5e 36 61 99 ce 92 91 b1 f6 30
    8c 1d b1 af d3 7b 38 3e e6 35
make[6]: *** [d:/build/mozilla-central/objdir-ff-release/dist/lib/softokn3.chk]
Error 5
make[6]: Leaving directory `/d/build/mozilla-central/security/nss/cmd/shlibsign'

make[5]: *** [libs] Error 2
maybe https://bugzilla.mozilla.org/show_bug.cgi?id=673197#c5
(Assignee)

Comment 9

6 years ago
I thought that this bug was about the build failing with gmake in a different way to pymake. If the build fails in the same way with both gmake and pymake then this bug is fixed, and any remaining issues are down to bug 674972.
Everything appears to work as it should now.
Can we close this?
I have no problems with closing this.  Any other problem would be a separate bug at this point.
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.