The default bug view has changed. See this FAQ.

browser_pageInfo.js leaks

RESOLVED FIXED

Status

()

Firefox
Page Info Window
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({mlk})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 542562 [details] [diff] [review]
patch

pageInfo.js never removes its callbacks (nor do the consumers remove themsevles), and browser_pageInfo.js doesn't remove its observer.
Attachment #542562 - Flags: review?(gavin.sharp)
I don't really understand why the pageInfo.js changes are needed. How are those arrays special such that the need to be explicitly released on unload?
(Assignee)

Comment 2

6 years ago
Anyone can add functions to the arrays. Add-ons do it and browser_bug517902.js does it.
I still don't see why that is a problem. Once the page info window goes away those references should die, whether you null them out explicitly or not.
(Assignee)

Comment 4

6 years ago
browser_bug517902.js also holds a reference to the window. I don't know how reliably such cycles are resolved. It's also possible that the observer part alone gets rid of the leaks.
(Assignee)

Comment 5

6 years ago
It looked like the pageInfo.js part fixed a bunch of about:blank leaks, but I'm getting unstable results now, so I just landed the browser_pageInfo.js fix.

http://hg.mozilla.org/mozilla-central/rev/03f27e11397f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Summary: Page Info and Page Info tests leak → browser_pageInfo.js leaks
(Assignee)

Updated

6 years ago
Attachment #542562 - Attachment is obsolete: true
Attachment #542562 - Flags: review?(gavin.sharp)
Blocks: 767896
You need to log in before you can comment on or make changes to this bug.