668013 - Add nsHTMLStyleSheet::SizeOf()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

Trying something...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 542633 [details] [diff] [review]
Patch v2

I wonder whether the |size += mFoo ? sizeof(*mFoo.get()) : 0| pattern could just use a macro...

>+  if (entry->mAttributes) {

mAttributes is never null.

The sizeof(nsIURI) thing there is of limited utility, for what it's worth.  It'll just claim to be one word, I bet.

>+    size += sizeof(MappedAttrTable_Ops);

Why?

>+    size += sizeof(*entry->mAttributes);

And I guess a followup to get nsMappedAttributes::SizeOf() ?

r=me with the nits fixed (in particular, take out or really explain the _Ops thing).

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> I wonder whether the |size += mFoo ? sizeof(*mFoo.get()) : 0| pattern could
> just use a macro...

I agree. Though, I will keep that for a follow-up. There are a few situations that could use a macro or a helper method.

> >+  if (entry->mAttributes) {
> 
> mAttributes is never null.

I've put an NS_ASSERTION.

> The sizeof(nsIURI) thing there is of limited utility, for what it's worth. 
> It'll just claim to be one word, I bet.

Do you mean:
> size += mURL ? sizeof(*mURL.get()) : 0;

> >+    size += sizeof(MappedAttrTable_Ops);
> 
> Why?

Removed. Sorry, that was stupid.

> >+    size += sizeof(*entry->mAttributes);
> 
> And I guess a followup to get nsMappedAttributes::SizeOf() ?

bug 667887

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Patch v3

r=bz

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch v3

Comment 6

[Mounir Lamouri (:mounir)]

Oups, comment 3 was expecting a reply from you Boris but you were not in CC ;)

Comment 7

[Boris Zbarsky [:bzbarsky]]

>Do you mean:
>> size += mURL ? sizeof(*mURL.get()) : 0;

Yes.  *mURL.get() is of type nsIURI, which is a class with nothing but a vtable and only one vtable pointer.

And come to think of it, the mURL of an nsHTMLStyleSheet is always the URI of the document.  So we should just not count it here at all (apart from the space the mURL COMPtr takes in nsHTMLStyleSheet, which sizeof(*this) covered.

Comment 8

[Marco Bonardo [:mak]]

this has been backed out by ehsan due to bustage with all the other changesets in the same push

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/1ec9c2051c07