668130 - Remove auditing code in fipstokn.c which breaks Solaris 11

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Ginn Chen]

"fipstokn.c", line 459: prototype mismatch: 3 args passed, 4 expected
"fipstokn.c", line 465: prototype mismatch: 3 args passed, 4 expected

The interface of au_close() is changed in snv_168.

-    int au_close(int d, int keep, short event);
+    int au_close(int d, int keep, au_event_t event, au_emod_t e_mod);

+    The e_mod variable indicates whether the audit record is
+    a success (0), or fail(PAD_FAILURE) record.

Comment 1

[Julien Pierre]

Indeed. It looks like the prototype for au_close has changed in s11 to take a 4th argument.

Comment 2

[Julien Pierre]

Attachment: Remove Solaris auditing code

This is not just a build issue, but also presents a runtime binary compatibility issue. I have consulted with the Solaris team.

Since Oracle isn't doing FIPS validations for NSS anymore on Solaris, their recommendation is to remove the auditing code.

Comment 3

[Wan-Teh Chang]

Attachment: Remove Solaris auditing code, v2

That code was added in this changeset:
https://hg.mozilla.org/projects/nss/rev/b4fdd7dfac22

I also removed the accompanying makefile changes.
The change to lib/softoken/config.mk has apparently
been replicated to the two new database directories.
So I removed them all.

Please test the new code. Thanks.

Comment 4

[Wan-Teh Chang]

Patch checked in: https://hg.mozilla.org/projects/nss/rev/e2698be0010b

Comment 5

[Julien Pierre]

Comment on attachment 8390522 [details] [diff] [review]
Remove Solaris auditing code, v2

Review of attachment 8390522 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching that. It builds fine.