668153 - wcap not working since TB5 and Lightning 1.0b4rc2

Status: RESOLVED FIXED

(Calendar :: Provider: WCAP, defect)

Description

[Sergio54]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

Recently upgraded to TB5 and latest Lightning 1.0b4rc2


Actual results:

I see the warning triangle and "The calendar xxx is momentarily not available" when I try to view the Wcap calendar.
it worked before changing and it works with Google Calendar.

Comment 1

[tarti]

Today I upgraded to TB5 and latest Lightning 1.0b4. Results : I have the same bug. My wcap doesn't work

It works with Google Calendar.

I downgrade with TB3 and  Lightning 1.0b2 and it works

warning log :

Avertissement : Une erreur est survenue lors de la lecture de données de l'agenda : PERRIN Valentin. Cependant, l'erreur est certainement mineure ; le programme va donc essayer de poursuivre. Code d'erreur : 0x80004005. Description : NS_ERROR_FAILURE

and 

Avertissement : Une erreur est survenue lors de la lecture de données de l'agenda : PERRIN Valentin. Cependant, l'erreur est certainement mineure ; le programme va donc essayer de poursuivre. Code d'erreur : READ_FAILED. Description : READ_FAILED

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Unfortunately we don't have a wcap server to test this. Could you provide us with one?

Comment 3

[tarti]

I couldn't provide a wcap server (it's a work server) but i can give you a file log if you explain me how to activate the error mode log of lightning

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

I can tell you how to enable, but tbh I probably can't make much of it. Anyway:

Options > Adanced > General > Config Editor.

Then, set:

calendar.wcap.log_level = 99
calendar.debug.log = true
calebndar.debug.log.verbose = true

Comment 5

[tarti]

I found the bug.

In the file /calendar-js/calWcapCalendarItems.js,  I found this :

cal.processPendingEvent; on line  977, 1013 and 1061

But this function have disappear since a previous version.

I tried to comment this call function and it's works.

if you want i have attache the correct file on this topic

Sorry for my english. I'm french.

Comment 6

[tarti]

Attachment: calWcapCalendarItems.js with no call on the cal.processPendingEvent function

Comment 7

[jens.poenninghaus]

Same behaviour seen in Bielefeld.
Seems like processPendingEvent was defined in modules/CalUtils.jsm (checked on pre3 build 2011-03-28) and disappeared.
Simple grep on subfolder of extension now just yields the mentioned calls, no function header.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Perfect, sounds like an easy fix, seems I forgot to remove all traces of that function. I'll need a patch in mercurials diff format with http://hg.mozilla.org/comm-central, then I can push it. If someone wants to do this for me, I'd appreciate. Otherwise I'll put this on my todo list.

Comment 9

[Matthew Mecca [:mmecca]]

Attachment: patch v1

Comment 10

[Matthew Mecca [:mmecca]]

Comment on attachment 544095 [details] [diff] [review]
patch v1

These are the changes from comment #5, but I don't have access to a wcap server to test if this fixes the problem or not.

Comment 11

[jens.poenninghaus]

Got feedback from a few users on a 'comment out the calls patch' for a couple of days. They report to have seen no negative effects yet.
@Philipp Kewisch: Test accounts on wcap server provided some time ago are still valid. You are welcome to use them for development/debugging purposes.

Comment 12

[Laurent Bauvens]

I manually change the file calWcapCalendarItems.js in the same way as Tarti did in comment #5 and my access to our Calendar Server is well back.

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Jens, thanks for the note. I forgot I had them and will look in my emails. Anyway, I think since enough people have tested this its ok to take the patch. This will be included in the 1.0b5 release which is due in the next week (urgent bugfix release)

Comment 14

[Jean-Francois Weber]

FYI we had exactly the same bug and the fix is working for us now. Hope it will be embeded in a next release. Thanks a lot for your prompt reactivity.

Comment 15

[Martin Schröder [:mschroeder]]

Comment on attachment 544095 [details] [diff] [review]
patch v1

Looks good and seems to work just fine! r=mschroeder

Comment 16

[benoitlabarthe]

Hi, I had the same bug, the solution from Tarti worked fine for me.
thanks to all.

Comment 17

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/8961a80e383c>
-> FIXED

Comment 18

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/c69062fc3779>

Comment 19

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/2e7f3817df11>