668291 - IonMonkey: Free allocated stack slots at the end of intervals in the register allocator

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Drake [:adrake]]

Currently stack slots once assigned are not reused, this is a tracking bug for the appropriate FIXME in the code.

Comment 1

[Andrew Drake [:adrake]]

Attachment: Patch v0

Applies on top of patch v0 from bug 657816.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 543337 [details] [diff] [review]
Patch v0

Review of attachment 543337 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, this patch invalidates most of my comment about |handled| in the base patch - if it is unused in release code though, it still deserves an #ifdef DEBUG

::: js/src/ion/RegisterAllocator.cpp
@@ +782,5 @@
> +    LAllocation *alloc = interval->getAllocation();
> +    JS_ASSERT(!alloc->isUse());
> +
> +    if (alloc->isStackSlot())
> +        stackAssignment.freeSlot(alloc->toStackSlot()->slot());

This should check whether the slot is double or not and call freeDoubleSlot instead.

Comment 3

[Andrew Drake [:adrake]]

http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/aa0a554ed868