668295 - IonMonkey: Implement allocation reification stage of linear scan register allocator

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Drake [:adrake]]

Tracking bug for the associated FIXME in the code

Comment 1

[Andrew Drake [:adrake]]

Attachment: Patch v0 (WIP)

Lots of room for optimization here, although it seems quite performant already. This is a WIP, it needs to be refactored a tiny bit and to gain more assertions. Additionally, there appears to be an issue wherein lowered unboxes for function parameters have snapshots containing entries for sequentially later instructions, which I am obviously unable to fill in.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 544434 [details] [diff] [review]
Patch v0 (WIP)

Review of attachment 544434 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonLIR.h
@@ +707,4 @@
>          JS_ASSERT(i < numSlots_);
>          return &slots_[i];
>      }
> +    void setEntry(size_t i, LAllocation alloc) {

const LAllocation &alloc

@@ +751,4 @@
>          }
>      }
>  
> +    void replace(LAllocation alloc) {

Ditto

Comment 3

[Andrew Drake [:adrake]]

http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/9699e051002d