Closed
Bug 668312
Opened 14 years ago
Closed 14 years ago
Report only probes defined in TelemetryHistograms.h
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: taras.mozilla, Unassigned)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [inbound])
Attachments
(1 file)
|
6.18 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
This patch adds a .static property to histograms to block histograms created with nsITelemetry::newHistogram from being reported to the metrics server. newHistogram is mainly useful for testing at the moment. This will prevent addons from reporting new histograms via telemetry.
I would like to eventually support telemetry in addons and give addon authors access to the aggregated data, but we aren't ready for that in Firefox 7.
Attachment #542908 -
Flags: review?(dtownsend)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 542908 [details] [diff] [review]
Do not report dynamic histograms
Review of attachment 542908 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/telemetry/nsITelemetry.idl
@@ +38,4 @@
>
> #include "nsISupports.idl"
>
> +[scriptable, uuid(7c3d748c-5a70-4cc8-98f2-f4a915e5499c)]
No need to change the IID here.
Attachment #542908 -
Flags: review?(dtownsend) → review+
|
Reporter | |
Comment 2•14 years ago
|
||
Need to document that telemetry histograms defined with nsITelemetry::newHistogram will not be reported in the telemetry ping.
http://hg.mozilla.org/integration/mozilla-inbound/rev/86518f461037
Keywords: dev-doc-needed
Whiteboard: [inbound]
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•