Closed Bug 668312 Opened 9 years ago Closed 9 years ago

Report only probes defined in TelemetryHistograms.h

Categories

(Toolkit :: Telemetry, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: taras.mozilla, Unassigned)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [inbound])

Attachments

(1 file)

This patch adds a .static property to histograms to block histograms created with nsITelemetry::newHistogram from being reported to the metrics server. newHistogram is mainly useful for testing at the moment. This will prevent addons from reporting new histograms via telemetry.

I would like to eventually support telemetry in addons and give addon authors access to the aggregated data, but we aren't ready for that in Firefox 7.
Attachment #542908 - Flags: review?(dtownsend)
Comment on attachment 542908 [details] [diff] [review]
Do not report dynamic histograms

Review of attachment 542908 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/nsITelemetry.idl
@@ +38,4 @@
>  
>  #include "nsISupports.idl"
>  
> +[scriptable, uuid(7c3d748c-5a70-4cc8-98f2-f4a915e5499c)]

No need to change the IID here.
Attachment #542908 - Flags: review?(dtownsend) → review+
Need to document that telemetry histograms defined with nsITelemetry::newHistogram will not be reported in the telemetry ping.

http://hg.mozilla.org/integration/mozilla-inbound/rev/86518f461037
Keywords: dev-doc-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/86518f461037
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.