Last Comment Bug 668312 - Report only probes defined in TelemetryHistograms.h
: Report only probes defined in TelemetryHistograms.h
: dev-doc-complete
Product: Toolkit
Classification: Components
Component: Telemetry (show other bugs)
: unspecified
: x86 Linux
-- normal (vote)
: mozilla7
Assigned To: Nobody; OK to take it and work on it
: Georg Fritzsche [:gfritzsche]
Depends on:
Blocks: 659396
  Show dependency treegraph
Reported: 2011-06-29 12:31 PDT by (dormant account)
Modified: 2011-07-03 03:19 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Do not report dynamic histograms (6.18 KB, patch)
2011-06-29 12:31 PDT, (dormant account)
dtownsend: review+
Details | Diff | Splinter Review

Description User image (dormant account) 2011-06-29 12:31:04 PDT
Created attachment 542908 [details] [diff] [review]
Do not report dynamic histograms

This patch adds a .static property to histograms to block histograms created with nsITelemetry::newHistogram from being reported to the metrics server. newHistogram is mainly useful for testing at the moment. This will prevent addons from reporting new histograms via telemetry.

I would like to eventually support telemetry in addons and give addon authors access to the aggregated data, but we aren't ready for that in Firefox 7.
Comment 1 User image Dave Townsend [:mossop] 2011-06-29 15:35:18 PDT
Comment on attachment 542908 [details] [diff] [review]
Do not report dynamic histograms

Review of attachment 542908 [details] [diff] [review]:

::: toolkit/components/telemetry/nsITelemetry.idl
@@ +38,4 @@
>  #include "nsISupports.idl"
> +[scriptable, uuid(7c3d748c-5a70-4cc8-98f2-f4a915e5499c)]

No need to change the IID here.
Comment 2 User image (dormant account) 2011-06-30 15:02:09 PDT
Need to document that telemetry histograms defined with nsITelemetry::newHistogram will not be reported in the telemetry ping.
Comment 3 User image Marco Bonardo [::mak] 2011-07-02 02:30:02 PDT

Note You need to log in before you can comment on or make changes to this bug.