668319 - Allow to set opacity on ::-moz-tree-cell-text

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

same as bug 664127 but for moz-cell-text. Unfortunately the icon is not enough for cut, since in some view users may hide icons, so I need to be able to set text opacity differently from the icon (the text should be more readable).

While the patch is trivial (same as the other bug, but in PaintText), I'm unable to make a reftest for this, the fact that I set opacity on the tree or on the cell-text makes subpixel-AA act differently and the test fails even if looking at screenshots they are equal.
I've tried using sans-serif or monospace, adding padding or other tricks I've seen in other reftests, but no luck.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Any idea what I could try to solve the subpixel-AA problem?
I thought the easy way to test this was just to add a label and opacity on cell-test to the test I added in bug 664127, but I have not find a way to bypass that issue.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

Nevermind, I found a way.  Using opacity: 0 I ensure opacity works and at the same time there is no antialiasing risk since nothing appears.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 542955 [details] [diff] [review]
patch v1.1

Review of attachment 542955 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

pushed with other stuff, will merge as soon as I get a green run
http://hg.mozilla.org/projects/places/rev/f76ebe0465e1

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/f76ebe0465e1