Closed Bug 668319 Opened 9 years ago Closed 9 years ago

Allow to set opacity on ::-moz-tree-cell-text

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fixed-in-places])

Attachments

(1 file, 1 obsolete file)

same as bug 664127 but for moz-cell-text. Unfortunately the icon is not enough for cut, since in some view users may hide icons, so I need to be able to set text opacity differently from the icon (the text should be more readable).

While the patch is trivial (same as the other bug, but in PaintText), I'm unable to make a reftest for this, the fact that I set opacity on the tree or on the cell-text makes subpixel-AA act differently and the test fails even if looking at screenshots they are equal.
I've tried using sans-serif or monospace, adding padding or other tricks I've seen in other reftests, but no luck.
Attached patch patch v1.0 (obsolete) — Splinter Review
Any idea what I could try to solve the subpixel-AA problem?
I thought the easy way to test this was just to add a label and opacity on cell-test to the test I added in bug 664127, but I have not find a way to bypass that issue.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #542914 - Flags: review?(roc)
Attached patch patch v1.1Splinter Review
Nevermind, I found a way.  Using opacity: 0 I ensure opacity works and at the same time there is no antialiasing risk since nothing appears.
Attachment #542914 - Attachment is obsolete: true
Attachment #542955 - Flags: review?(roc)
Attachment #542914 - Flags: review?(roc)
Comment on attachment 542955 [details] [diff] [review]
patch v1.1

Review of attachment 542955 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #542955 - Flags: review?(roc) → review+
pushed with other stuff, will merge as soon as I get a green run
http://hg.mozilla.org/projects/places/rev/f76ebe0465e1
Whiteboard: [fixed-in-places]
http://hg.mozilla.org/mozilla-central/rev/f76ebe0465e1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.