nsStringBuffer reported leak in xpcshell tests

RESOLVED FIXED in Thunderbird 7.0

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Bienvenu, Unassigned)

Tracking

({memory-leak})

Trunk
Thunderbird 7.0
x86
Windows 7
memory-leak

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 543008 [details] [diff] [review]
proposed fix

xpcshell tests are reporting an nsStringBuffer leak (and we get a warning about a static nsCString destructor). Turns out this was introduced by the fix for bug 207156 where Mike made the kWhiteSpace member variable a static string instead, which in the normal world would be a reasonable optimization, but in our world produces a string leak warning on all our tests (on Windows, at least). I changed the test to just test for each whitespace char - it's not like anyone is going to be inventing new ascii whitespace chars.
Attachment #543008 - Flags: review?(mbanner)
Attachment #543008 - Flags: review?(mbanner) → review+
(Reporter)

Comment 1

8 years ago
http://hg.mozilla.org/comm-central/rev/1a874442f742
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in before you can comment on or make changes to this bug.