Closed Bug 668393 Opened 10 years ago Closed 10 years ago

nsStringBuffer reported leak in xpcshell tests

Categories

(MailNews Core :: Import, defect)

Product:
MailNews Core
Component:
Import
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 7.0

People

(Reporter: Bienvenu, Unassigned)

References

Details

(Keywords: memory-leak)

Attachments

(1 file)

proposed fix
1.76 KB, patch
standard8
: review+
Details | Diff | Splinter Review
Attached patch proposed fix — — Splinter Review 
xpcshell tests are reporting an nsStringBuffer leak (and we get a warning about a static nsCString destructor). Turns out this was introduced by the fix for bug 207156 where Mike made the kWhiteSpace member variable a static string instead, which in the normal world would be a reasonable optimization, but in our world produces a string leak warning on all our tests (on Windows, at least). I changed the test to just test for each whitespace char - it's not like anyone is going to be inventing new ascii whitespace chars.
Attachment #543008 - Flags: review?(mbanner)
Attachment #543008 - Flags: review?(mbanner) → review+
http://hg.mozilla.org/comm-central/rev/1a874442f742
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in before you can comment on or make changes to this bug.