move test_focusrings.xul to mochitest-chrome

ASSIGNED
Assigned to

Status

()

Product:
Core
Component:
General
Status:
ASSIGNED
Reported:
7 years ago
Modified:
4 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

Version:
Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [specialpowers])

Attachments

(1 attachment)

move test_focusrings.xul to chrome (1.0)
4.84 KB, patch
enndeakin
: review-
Details | Diff | Splinter Review
(Assignee)

Description

•
7 years ago 
we should move test_focusrings.xul to mochitest-chrome.
 (Assignee)

Comment 1

•
7 years ago 
Created attachment 543038 [details] [diff] [review]
move test_focusrings.xul to chrome (1.0)

Neil, can you review this patch and ensure that if it is moved to chrome we will gain the same test coverage?
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #543038 - Flags: review?(enndeakin)

Comment 2

•
7 years ago 
Comment on attachment 543038 [details] [diff] [review]
move test_focusrings.xul to chrome (1.0)

>-      prefs.clearUserPref("tabfocus");
>+    if (SpecialPowers.prefHasUserValue("tabfocus")) {

This one method isn't defined.

Updated

•
7 years ago
Attachment #543038 - Flags: review?(enndeakin) → review-
 (Assignee)

Comment 3

•
4 years ago 
this is an old bug, shall we close it as wontfix?
You need to log in before you can comment on or make changes to this bug.