668499 - Move D2A out of MathUtils.cpp/h, to make them visible outside those files

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Lars T Hansen]

Attachment: Patch

This is a simple refactoring, again I've cleaned up comments and so on but there should be no functionality changes here at all.  As the summary says, the point here is to make the D2A utility class available to more than the MathUtils.{cpp,h} files: future a2d/d2a bug fixing will happen in more than one file, and will need access to this code.

I apologize for introducing new files.

Comment 1

[Lars T Hansen]

Note, it may be tricky to apply this if not applying the patch for bug #668470 first, but I don't know that for a fact.  But it was developed on top of that.

Comment 2

[Steven Johnson]

Comment on attachment 543122 [details] [diff] [review]
Patch

Review of attachment 543122 [details] [diff] [review]:
-----------------------------------------------------------------

R+, but can I inquire what else is using this?

Comment 3

[Lars T Hansen]

> R+, but can I inquire what else is using this?

Future a2d/d2a bug fixing will happen in more than one file because algorithms are likely to be factored on the macro level and the macro factoring will likely spread to multiple files.  (The number of bugs in the current implementations makes it messy to apply spot bug fixes without significant risk to either existing semantics or future maintainability.)

Comment 4

[Tamarin Bot]

changeset: 6546:815b301e1dd0
user:      Lars T Hansen <[e-mail]>
summary:   Fix 668499 - Move D2A out of MathUtils.cpp/h, to make them visible outside those files (r=stejohns)

http://hg.mozilla.org/tamarin-redux/rev/815b301e1dd0