66850 - when opening the local trash folder (on first delete) batch the updates to the unread count

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

try this:

have 1000 unread messages in your trash
start up, don't load the trash, select your inbox.
delete a message.

deleting a message causes us to open the trash.  we'll update the unread count
once per message, instead of in batch.

Comment 1

[(not reading, please use [e-mail] instead)]

happens to me every time I start up and delete a message, since I've got unread
mail in my trash.

Comment 2

[David :Bienvenu]

Are you talking about IMAP? We should not be issuing an IMAP select when
deleting a message to the trash, and it sounds like you're saying we do. If so,
that's a regression.

Comment 3

[(not reading, please use [e-mail] instead)]

this was on pop.  I'll double check what happens for imap.

Comment 4

[David :Bienvenu]

ah, ok, that makes sense, and I've seen it happen as well. What's happening is
that attempting to open the trash db is causing the trash folder to get reparsed
and the db recreated. Batching the count updates would be a fine thing to do.
The trash db should not be gettng out of sync as often as it is, however.

Comment 5

[(not reading, please use [e-mail] instead)]

naving may have fixed this.

naving, did you make it so we don't open the trash folder on delete?

Comment 6

[David :Bienvenu]

No, Navin made it so we don't download imap headers for the trash on undo. We
still open the db (and we need to).

Comment 7

[scottputterman]

moving to mozilla0.9

Comment 8

[scottputterman]

marking nsbeta1+.

Comment 9

[scottputterman]

Are you still seeing this?  I've been playing around with my Local Folders trash
folder and it never seems to need to be reparse.  I have 1083 unread messages.

Comment 10

[David :Bienvenu]

I fixed a few problems that were causing the trash folder+db to get out of sync
so this should be much harder to recreate.

Comment 11

[scottputterman]

Great.  Then moving to 0.9.2.  If what's left is still noticeable then we can
fix it then or else I'll just move this to the future milestone.

Comment 12

[scottputterman]

moving to 0.9.3

Comment 13

[scottputterman]

moving to 0.9.4

Comment 14

[(not reading, please use [e-mail] instead)]

slide to 0.9.5

Comment 15

[(not reading, please use [e-mail] instead)]

moving out.

Comment 16

[scottputterman]

moving to future.  If you think this is something that needs to be fixed (it
sounds like we've reduced the potential cases where this could happen), let me know.

Comment 17

[Jesse Ruderman]

I had 1000 unread of 7000 messages in my trash, and noticed that the first
delete was always slow (1-2 seconds).  After reading this bug, I tried marking
all the messages in my trash as unread and restarting, but deleting the first
message is still slow.

Comment 18

[Wayne Mery (:wsmwk)]

problem gone?   was this pop-only (comment 3)?

Comment 19

[Andrew Schultz]

I don't see this, perhaps due to comment 10 or other similar fixes.

Comment 20

[Wayne Mery (:wsmwk)]

=> WFM per andrew