Last Comment Bug 668515 - Remove intl xpcshell-test platform-specific directories
: Remove intl xpcshell-test platform-specific directories
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Internationalization (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Simon Montagu :smontagu
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-30 08:30 PDT by Simon Montagu :smontagu
Modified: 2011-07-14 09:32 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (6.92 KB, patch)
2011-06-30 08:30 PDT, Simon Montagu :smontagu
no flags Details | Diff | Review
patch (8.26 KB, patch)
2011-06-30 08:39 PDT, Simon Montagu :smontagu
no flags Details | Diff | Review
patch (8.27 KB, patch)
2011-06-30 08:47 PDT, Simon Montagu :smontagu
ted: review+
Details | Diff | Review
followup: fix toolkit-makefiles.sh (1.04 KB, patch)
2011-07-11 10:54 PDT, Daniel Holbert [:dholbert]
khuey: review+
Details | Diff | Review

Description Simon Montagu :smontagu 2011-06-30 08:30:57 PDT
Created attachment 543137 [details] [diff] [review]
patch

We have some directories under intl/locale which only exist so that we can run platform-specific xpcshell tests. With bug 664197, all the tests can unified in one directory.
Comment 1 Simon Montagu :smontagu 2011-06-30 08:39:52 PDT
Created attachment 543140 [details] [diff] [review]
patch
Comment 2 Simon Montagu :smontagu 2011-06-30 08:47:40 PDT
Created attachment 543142 [details] [diff] [review]
patch
Comment 3 Ted Mielczarek [:ted.mielczarek] 2011-07-01 10:57:46 PDT
Comment on attachment 543142 [details] [diff] [review]
patch

Review of attachment 543142 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!
Comment 4 Simon Montagu :smontagu 2011-07-02 23:40:22 PDT
http://hg.mozilla.org/mozilla-central/rev/bd7d3f2d51ad
Comment 5 Daniel Holbert [:dholbert] 2011-07-11 10:54:50 PDT
Created attachment 545209 [details] [diff] [review]
followup: fix toolkit-makefiles.sh

>diff --git a/intl/locale/tests_multilocale/Makefile.in b/intl/locale/tests_multilocale/Makefile.in
>deleted file mode 100644

Now we get this buildspam:
> can't read intl/locale/tests_multilocale/Makefile.in: No such file or directory

This bug's fix was missing an update to toolkit-makefiles.sh.  Patch attached.
Comment 6 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-13 11:19:24 PDT
Comment on attachment 545209 [details] [diff] [review]
followup: fix toolkit-makefiles.sh

rs=me to do this kind of cleanup without asking in the future
Comment 7 Daniel Holbert [:dholbert] 2011-07-13 12:39:58 PDT
Landed toolkit-makefiles.sh fixup:
 http://hg.mozilla.org/integration/mozilla-inbound/rev/ab7b30a409d3
Comment 8 :Ehsan Akhgari (busy, don't ask for review please) 2011-07-14 09:32:20 PDT
http://hg.mozilla.org/mozilla-central/rev/ab7b30a409d3

Note You need to log in before you can comment on or make changes to this bug.