Remove intl xpcshell-test platform-specific directories

RESOLVED FIXED

Status

()

Core
Internationalization
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smontagu, Assigned: smontagu)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 543137 [details] [diff] [review]
patch

We have some directories under intl/locale which only exist so that we can run platform-specific xpcshell tests. With bug 664197, all the tests can unified in one directory.
(Assignee)

Comment 1

6 years ago
Created attachment 543140 [details] [diff] [review]
patch
Attachment #543137 - Attachment is obsolete: true
(Assignee)

Comment 2

6 years ago
Created attachment 543142 [details] [diff] [review]
patch
Attachment #543140 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #543142 - Flags: review?(ted.mielczarek)
Comment on attachment 543142 [details] [diff] [review]
patch

Review of attachment 543142 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!
Attachment #543142 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/bd7d3f2d51ad
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Created attachment 545209 [details] [diff] [review]
followup: fix toolkit-makefiles.sh

>diff --git a/intl/locale/tests_multilocale/Makefile.in b/intl/locale/tests_multilocale/Makefile.in
>deleted file mode 100644

Now we get this buildspam:
> can't read intl/locale/tests_multilocale/Makefile.in: No such file or directory

This bug's fix was missing an update to toolkit-makefiles.sh.  Patch attached.
Attachment #545209 - Flags: review?(ted.mielczarek)
Attachment #545209 - Flags: review?(ted.mielczarek) → review?(khuey)
Comment on attachment 545209 [details] [diff] [review]
followup: fix toolkit-makefiles.sh

rs=me to do this kind of cleanup without asking in the future
Attachment #545209 - Flags: review?(khuey) → review+
Landed toolkit-makefiles.sh fixup:
 http://hg.mozilla.org/integration/mozilla-inbound/rev/ab7b30a409d3
http://hg.mozilla.org/mozilla-central/rev/ab7b30a409d3
You need to log in before you can comment on or make changes to this bug.