Closed Bug 668515 Opened 12 years ago Closed 12 years ago

Remove intl xpcshell-test platform-specific directories

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

Details

Attachments

(2 files, 2 obsolete files)

patch
8.27 KB, patch
ted
: review+
Details | Diff | Splinter Review
followup: fix toolkit-makefiles.sh
1.04 KB, patch
khuey
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
We have some directories under intl/locale which only exist so that we can run platform-specific xpcshell tests. With bug 664197, all the tests can unified in one directory.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #543137 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #543140 -
        Attachment is obsolete: true

    
  

        Attachment #543142 -
        Flags: review?(ted.mielczarek)

    
    

    
  
Comment on attachment 543142 [details] [diff] [review]
patch

Review of attachment 543142 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!

        Attachment #543142 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/bd7d3f2d51ad
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
    

    
  


  
>diff --git a/intl/locale/tests_multilocale/Makefile.in b/intl/locale/tests_multilocale/Makefile.in
>deleted file mode 100644

Now we get this buildspam:
> can't read intl/locale/tests_multilocale/Makefile.in: No such file or directory

This bug's fix was missing an update to toolkit-makefiles.sh.  Patch attached.

        Attachment #545209 -
        Flags: review?(ted.mielczarek)

        Attachment #545209 -
        Flags: review?(ted.mielczarek) → review?(khuey)

    
    

    
  
Comment on attachment 545209 [details] [diff] [review]
followup: fix toolkit-makefiles.sh

rs=me to do this kind of cleanup without asking in the future

        Attachment #545209 -
        Flags: review?(khuey) → review+

          You need to log in
          before you can comment on or make changes to this bug.