668515 - Remove intl xpcshell-test platform-specific directories

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Simon Montagu :smontagu]

Attachment: patch

We have some directories under intl/locale which only exist so that we can run platform-specific xpcshell tests. With bug 664197, all the tests can unified in one directory.

Comment 1

[Simon Montagu :smontagu]

Attachment: patch

Comment 2

[Simon Montagu :smontagu]

Attachment: patch

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 543142 [details] [diff] [review]
patch

Review of attachment 543142 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!

Comment 4

[Simon Montagu :smontagu]

http://hg.mozilla.org/mozilla-central/rev/bd7d3f2d51ad

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: followup: fix toolkit-makefiles.sh

>diff --git a/intl/locale/tests_multilocale/Makefile.in b/intl/locale/tests_multilocale/Makefile.in
>deleted file mode 100644

Now we get this buildspam:
> can't read intl/locale/tests_multilocale/Makefile.in: No such file or directory

This bug's fix was missing an update to toolkit-makefiles.sh.  Patch attached.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 545209 [details] [diff] [review]
followup: fix toolkit-makefiles.sh

rs=me to do this kind of cleanup without asking in the future

Comment 7

[Daniel Holbert [:dholbert]]

Landed toolkit-makefiles.sh fixup:
 http://hg.mozilla.org/integration/mozilla-inbound/rev/ab7b30a409d3

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/ab7b30a409d3