668550 - python should have some way of transfering data to the test on the JS side

Status: RESOLVED WORKSFORME

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L313

goes to 

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/frame.js#L586

There should be an additional argument, e.g. `options`, that will be
added to the (module global) namespace of the test.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So this is only for the initial test execution? What about information we could send over to the test from Python which gets triggered e.g. by an event listener from the test (JS) side? Would that also be covered by that bug? I would say no, or am I wrong?

Comment 2

[Jeff Hammel]

Yes, the scope of this is just transfering data to the test.  Transfering data from JS is done with event listeners, and sharing information is covered by JS objects. These three cases should cover about everything mozmill is currently scoped to do.  Ultimately, we would want better (albeit, not more) xfer mechanisms, but that would be a major rewrite

Comment 3

[cmtalbert]

That's a good idea as a simple means to transfer data into a test.  Henrik, I don't understand why you'd want to transfer data from python into a running js test conditioned on some event happening in js.  That seems incredibly fragile and prone to all kinds of race and timing issues.  What use case does that solve?

I think that allowing python to be able to pass an object of data into a test before the test is run would be a fine thing and should cover just about every case I can think of.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That's what we have with persisted object for a long time now, right?