The default bug view has changed. See this FAQ.

remove JSSecurityCallbacks::subsumePrincipals

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
With compartments we've been ripping out JSPrincipals::subsume calls.  There are only two remaining uses: EvalCacheLookup and obj_watch_handler.  The former is probably unnecessary since the table is per-compartment.  The latter may be as well but Jason remembers that we failed to remove it earlier for some reason that perhaps Blake knows...

With JSPrincipals::subsume removed, JSPrincipals is just an opaque ref-counted annotation on scripts which is a heck of a lot less scary from a JS-hacker's perspective.  (With compartment-per-global, script->principals can be removed which (as well as all these principal-taking JSAPIs) since the principal will necessarily be == compartment->principals.)
(Assignee)

Comment 1

6 years ago
Created attachment 554911 [details] [diff] [review]
removed

Here's the patch to do it.  With document.domain, the EvalCacheLookup subsume check seems to want compartment-per-global.  Any chance I'm wrong mrbkap?
Assignee: general → luke
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Depends on: 650353
(Assignee)

Comment 2

5 years ago
Created attachment 654006 [details] [diff] [review]
rm

Let's do this.
Attachment #554911 - Attachment is obsolete: true
Attachment #654006 - Flags: review?(mrbkap)
(Assignee)

Comment 3

5 years ago
Created attachment 654008 [details] [diff] [review]
rm

Err, not that, this.
Attachment #654006 - Attachment is obsolete: true
Attachment #654006 - Flags: review?(mrbkap)
Attachment #654008 - Flags: review?(mrbkap)
(Assignee)

Updated

5 years ago
Summary: remove JSPrincipals::subsume → remove JSSecurityCallbacks::subsumePrincipals
(Assignee)

Updated

5 years ago
Attachment #654008 - Flags: review?(mrbkap)
(Assignee)

Comment 4

5 years ago
Created attachment 654386 [details] [diff] [review]
rm

Rebased
Attachment #654008 - Attachment is obsolete: true
Attachment #654386 - Flags: review?(mrbkap)
Comment on attachment 654386 [details] [diff] [review]
rm

Nice to see this go.
Attachment #654386 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/00646164061d
https://hg.mozilla.org/mozilla-central/rev/00646164061d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.