668558 - remove JSSecurityCallbacks::subsumePrincipals

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

With compartments we've been ripping out JSPrincipals::subsume calls.  There are only two remaining uses: EvalCacheLookup and obj_watch_handler.  The former is probably unnecessary since the table is per-compartment.  The latter may be as well but Jason remembers that we failed to remove it earlier for some reason that perhaps Blake knows...

With JSPrincipals::subsume removed, JSPrincipals is just an opaque ref-counted annotation on scripts which is a heck of a lot less scary from a JS-hacker's perspective.  (With compartment-per-global, script->principals can be removed which (as well as all these principal-taking JSAPIs) since the principal will necessarily be == compartment->principals.)

Comment 1

[Luke Wagner [:luke]]

Attachment: removed

Here's the patch to do it.  With document.domain, the EvalCacheLookup subsume check seems to want compartment-per-global.  Any chance I'm wrong mrbkap?

Comment 2

[Luke Wagner [:luke]]

Attachment: rm

Let's do this.

Comment 3

[Luke Wagner [:luke]]

Attachment: rm

Err, not that, this.

Comment 4

[Luke Wagner [:luke]]

Attachment: rm

Rebased

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 654386 [details] [diff] [review]
rm

Nice to see this go.

Comment 6

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00646164061d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00646164061d