add xpcshell test for pop3 duplicate handling

RESOLVED FIXED in Thunderbird 7.0

Status

MailNews Core
Networking: POP
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Trunk
Thunderbird 7.0
x86
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
in preparation for the pluggable store landing, we should have a unit test for the pop3 duplicate handling actions (or at least the one to delete duplicates, which is the slightly tricky one)
(Assignee)

Comment 1

7 years ago
Created attachment 543190 [details] [diff] [review]
proposed fix

unit test only patch, that makes sure delete duplicate action works. I wrote this for the pluggable store work but it can land separately.
Attachment #543190 - Flags: review?(mbanner)
Comment on attachment 543190 [details] [diff] [review]
proposed fix

Review of attachment 543190 [details] [diff] [review]:
-----------------------------------------------------------------

::: a/mailnews/local/test/unit/test_pop3Duplicates.js
@@ +30,5 @@
> +  while (enumerator.hasMoreElements())
> +  {
> +    msgCount++;
> +    let hdr = enumerator.getNext().QueryInterface(Ci.nsIMsgDBHdr);
> +    do_check_eq(hdr.subject, testSubjects[msgCount - 1]);

You could do msgCount++ here, then you wouldn't need to do the ++ earlier, and the additional -1.
Attachment #543190 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

7 years ago
fixed, with comments addressed - http://hg.mozilla.org/comm-central/rev/2bfa709f04ce
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in before you can comment on or make changes to this bug.