668563 - add xpcshell test for pop3 duplicate handling

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[David :Bienvenu]

in preparation for the pluggable store landing, we should have a unit test for the pop3 duplicate handling actions (or at least the one to delete duplicates, which is the slightly tricky one)

Comment 1

[David :Bienvenu]

Attachment: proposed fix

unit test only patch, that makes sure delete duplicate action works. I wrote this for the pluggable store work but it can land separately.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 543190 [details] [diff] [review]
proposed fix

Review of attachment 543190 [details] [diff] [review]:
-----------------------------------------------------------------

::: a/mailnews/local/test/unit/test_pop3Duplicates.js
@@ +30,5 @@
> +  while (enumerator.hasMoreElements())
> +  {
> +    msgCount++;
> +    let hdr = enumerator.getNext().QueryInterface(Ci.nsIMsgDBHdr);
> +    do_check_eq(hdr.subject, testSubjects[msgCount - 1]);

You could do msgCount++ here, then you wouldn't need to do the ++ earlier, and the additional -1.

Comment 3

[David :Bienvenu]

fixed, with comments addressed - http://hg.mozilla.org/comm-central/rev/2bfa709f04ce