668572 - Inspect production data to see if we have payload_size NULL

Status: RESOLVED WORKSFORME

(Cloud Services :: Operations: Miscellaneous, task)

Description

[:Atoll]

+++ This bug was initially created as a clone of Bug #667074 +++

We found out that some payload sizes are NULL in the stage DB, and that broke the get_sizes API.

While it seemed to be an old problem (a new sync did not produce those) we will:

1/ control if prod has some 
2/ handle those gracefully in the code 
3/ avoid it in the future   (telliott suggests to add a NOT NULL in the db)

Comment 1

[:Atoll]

Formerly a multibug, this is now item #1 from comment #0:

Inspect production data to see if we have payload_size NULL anywhere besides staging.

Comment 2

[:Atoll]

Random samples do not show any payload_size NULL in one of our oldest databases (wp-db01, up 343 days).  Declining to investigate further as item #2, "handle those gracefully", will cover any instances that crop up.

Comment 3

[Toby Elliott [:telliott]]

Turns out that the client now has a way to do this that involves encrypting the deleted record in the payload. We can no longer purge them on the server side. 

We should probably consider a shorter ttl for deleted records, especially stuff like bookmarks that effectively doesn't have any.

Comment 4

[Philipp von Weitershausen [:philikon]]

As of storage format 2 (since >1 year) we set

  {deleted: true}

within the encrypted payload. See https://wiki.mozilla.org/Labs/Weave/Developer/StorageFormat#Version_2

Comment 5

[Toby Elliott [:telliott]]

Filed Bug 669338 to cover more aggressively deleting these