Inspect production data to see if we have payload_size NULL

RESOLVED WORKSFORME

Status

Cloud Services
Operations
RESOLVED WORKSFORME
7 years ago
7 years ago

People

(Reporter: atoll, Assigned: atoll)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

7 years ago
+++ This bug was initially created as a clone of Bug #667074 +++

We found out that some payload sizes are NULL in the stage DB, and that broke the get_sizes API.

While it seemed to be an old problem (a new sync did not produce those) we will:

1/ control if prod has some 
2/ handle those gracefully in the code 
3/ avoid it in the future   (telliott suggests to add a NOT NULL in the db)
(Assignee)

Comment 1

7 years ago
Formerly a multibug, this is now item #1 from comment #0:

Inspect production data to see if we have payload_size NULL anywhere besides staging.
Summary: Some payload_sizes are NULL → Inspect production data to see if we have payload_size NULL
(Assignee)

Comment 2

7 years ago
Random samples do not show any payload_size NULL in one of our oldest databases (wp-db01, up 343 days).  Declining to investigate further as item #2, "handle those gracefully", will cover any instances that crop up.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
Turns out that the client now has a way to do this that involves encrypting the deleted record in the payload. We can no longer purge them on the server side. 

We should probably consider a shorter ttl for deleted records, especially stuff like bookmarks that effectively doesn't have any.
As of storage format 2 (since >1 year) we set

  {deleted: true}

within the encrypted payload. See https://wiki.mozilla.org/Labs/Weave/Developer/StorageFormat#Version_2
Filed Bug 669338 to cover more aggressively deleting these
You need to log in before you can comment on or make changes to this bug.