668573 - alter database schema to prevent NULL payload sizes

Status: RESOLVED FIXED

(Cloud Services :: Operations: Miscellaneous, task)

Description

[:Atoll]

+++ This bug was initially created as a clone of Bug #667074 +++

We found out that some payload sizes are NULL in the stage DB, and that broke the get_sizes API.

While it seemed to be an old problem (a new sync did not produce those) we will:

1/ control if prod has some 
2/ handle those gracefully in the code 
3/ avoid it in the future   (telliott suggests to add a NOT NULL in the db)

Comment 1

[:Atoll]

Formerly a multibug, this is now item #3 from comment #0:

In the future, prohibit sync code from storing NULL in the payload_size column.

Comment 2

[Toby Elliott [:telliott]]

(In reply to comment #1)
> Formerly a multibug, this is now item #3 from comment #0:
> 
> In the future, prohibit sync code from storing NULL in the payload_size
> column.

If we're going to NOT NULL, make sure we default 0 as well.

Comment 3

[:Atoll]

Moving to Server: Sync.  Toby, can you r? me when the schema change is ready?

Comment 4

[Toby Elliott [:telliott]]

Attachment: adds a not null default 0 to the wbo tables

I believe that the alter is simply:

alter table wbo* change column payload_size payload_size int(11) NOT NULL DEFAULT 0;

Comment 5

[Tarek Ziadé (:tarek)]

Comment on attachment 543203 [details] [diff] [review]
adds a not null default 0 to the wbo tables

Looks good

Comment 6

[Toby Elliott [:telliott]]

Fixed in http://hg.mozilla.org/services/server-storage/rev/35cd784e92b9