Closed Bug 668672 Opened 9 years ago Closed 9 years ago

NEON detection in MSVC doesn't respect HAVE_ARM_NEON

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: derf, Assigned: derf)

References

Details

Attachments

(1 file)

Proposed fix
753 bytes, patch
jrmuizel
: review+
Details | Diff | Splinter Review
Attached patch Proposed fix — — Splinter Review 
The NEON detection added in bug 583958 accidentally checks HAVE_ARM_SIMD instead. This isn't a major issue because we don't actually compile for ARM on Windows yet, but it could cause confusion in the future.
Attachment #543299 - Attachment is patch: true
Attachment #543299 - Flags: review?(jmuizelaar)
Blocks: 583958
Attachment #543299 - Flags: review?(jmuizelaar) → review+
http://hg.mozilla.org/mozilla-central/rev/cda02ba7d48c
Assignee: nobody → tterribe
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.