NEON detection in MSVC doesn't respect HAVE_ARM_NEON

RESOLVED FIXED in mozilla8

Status

()

Product:
Core
Component:
XPCOM
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: derf, Assigned: derf)

Tracking

Version:
Trunk
Target:
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Proposed fix
753 bytes, patch
jrmuizel
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
Created attachment 543299 [details] [diff] [review]
Proposed fix

The NEON detection added in bug 583958 accidentally checks HAVE_ARM_SIMD instead. This isn't a major issue because we don't actually compile for ARM on Windows yet, but it could cause confusion in the future.
 (Assignee)

Updated

•
6 years ago
Attachment #543299 - Attachment is patch: true
Attachment #543299 - Flags: review?(jmuizelaar)
 (Assignee)

Updated

•
6 years ago
Blocks: 583958
Attachment #543299 - Flags: review?(jmuizelaar) → review+
 (Assignee)

Comment 1

•
6 years ago 
http://hg.mozilla.org/integration/mozilla-inbound/rev/cda02ba7d48c
Whiteboard: [inbound]

Comment 2

•
6 years ago 
http://hg.mozilla.org/mozilla-central/rev/cda02ba7d48c
Assignee: nobody → tterribe
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.