668690 - scripts blocked by CAPS are still fetched, starting with Fx 4

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[al_9x]

test page: <script src="script.js"></script>
policy: user_pref("capability.policy.default.javascript.enabled", "noAccess");

The above policy prevents script fetching in Fx 3.6 but not in 4 & 5

Comment 1

[al_9x]

Last good nightly: 2010-05-03
First bad nightly: 2010-05-04

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=83c887dff0da&tochange=d6bb0f9e9519

Comment 2

[Boris Zbarsky [:bzbarsky]]

Sounds like the HTML5 parser prefetch at work.  The script is not executed, of course.  I suppose we can condition it for scripts on whether script is enabled for the document...

In particular, nsScriptLoader::ProcessScriptElement does an enabled check, but nsScriptLoader::PreloadURI does not.

Jonas, any objections to adding it?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: When scripts are disabled, don't bother preloading them.

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/78406c193536

Comment 5

[Mounir Lamouri (:mounir)]

Merged:
http://hg.mozilla.org/mozilla-central/rev/78406c193536

Comment 6

[Eric Shepherd [:sheppy]]

This bug fix is listed on Firefox 8 for developers.