Specified window dimensions in openDialog aren't respected if sizeMode is persisted and set to maximized

RESOLVED FIXED in mozilla7

Status

()

RESOLVED FIXED
7 years ago
4 months ago

People

(Reporter: int3, Assigned: int3)

Tracking

unspecified
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
I believe this is related to bug 509828. If we are ignoring the persisted size attributes, we should probably set the persisted sizeMode attribute to 'normal', otherwise the specified window dimensions will still get ignored.
(Assignee)

Comment 1

7 years ago
Created attachment 543338 [details] [diff] [review]
Patch v1

This patch fixes the problem described.
(Assignee)

Updated

7 years ago
Blocks: 465186
(Assignee)

Updated

7 years ago
Attachment #543338 - Flags: review?(bzbarsky)
Neil, are you happy reviewing this?  If so, can you please steal the review?  I don't really feel qualified to review this...
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

7 years ago
Comment on attachment 543338 [details] [diff] [review]
Patch v1

Looks good to me.

I notice that content popups get a second crack at setting the size which is why they don't suffer from the persistent sizemode.
Attachment #543338 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

7 years ago
Created attachment 543891 [details] [diff] [review]
Patch v1 -- Removed git's 'index' line
http://hg.mozilla.org/mozilla-central/rev/ed0f5032ff40
Assignee: nobody → jezreel
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.