Closed
Bug 668711
Opened 14 years ago
Closed 14 years ago
Specified window dimensions in openDialog aren't respected if sizeMode is persisted and set to maximized
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: int3, Assigned: int3)
References
Details
Attachments
(2 files)
|
1.80 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
|
1.77 KB,
patch
|
Details | Diff | Splinter Review |
I believe this is related to bug 509828. If we are ignoring the persisted size attributes, we should probably set the persisted sizeMode attribute to 'normal', otherwise the specified window dimensions will still get ignored.
|
Assignee | |
Comment 1•14 years ago
|
||
This patch fixes the problem described.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #543338 -
Flags: review?(bzbarsky)
|
||
Comment 2•14 years ago
|
||
Neil, are you happy reviewing this? If so, can you please steal the review? I don't really feel qualified to review this...
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 3•14 years ago
|
||
Comment on attachment 543338 [details] [diff] [review]
Patch v1
Looks good to me.
I notice that content popups get a second crack at setting the size which is why they don't suffer from the persistent sizemode.
Attachment #543338 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•14 years ago
|
||
|
||
Comment 5•14 years ago
|
||
Assignee: nobody → jezreel
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
|
||
Comment 6•7 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•