Closed Bug 668711 Opened 10 years ago Closed 10 years ago

Specified window dimensions in openDialog aren't respected if sizeMode is persisted and set to maximized

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: int3, Assigned: int3)

References

Details

Attachments

(2 files)

I believe this is related to bug 509828. If we are ignoring the persisted size attributes, we should probably set the persisted sizeMode attribute to 'normal', otherwise the specified window dimensions will still get ignored.
Attached patch Patch v1Splinter Review
This patch fixes the problem described.
Blocks: 465186
Attachment #543338 - Flags: review?(bzbarsky)
Neil, are you happy reviewing this?  If so, can you please steal the review?  I don't really feel qualified to review this...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 543338 [details] [diff] [review]
Patch v1

Looks good to me.

I notice that content popups get a second crack at setting the size which is why they don't suffer from the persistent sizemode.
Attachment #543338 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/ed0f5032ff40
Assignee: nobody → jezreel
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.