Open Bug 668716 Opened 13 years ago Updated 2 months ago

Intermittent TEST-UNEXPECTED-PASS test_bug632379.xhtml,test_bug632379.xul | Popup should open in the same place when the menu is scrolled - 109 should equal 109 since it got moved to mochitest-chrome

Categories

(Core :: Layout, defect, P5)

Product:
Core
Component:
Layout
Platform:
All
macOS
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox14 --- fixed
firefox15 - fixed

People

(Reporter: philor, Unassigned)

References

(
URL
)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [test disabled on mac])

Attachments

(1 file, 5 obsolete files)

Disable test on Mac
1.29 KB, patch
philor
: review+
akeybl
: approval-mozilla-beta+
emorley
: checkin+
Details | Diff | Splinter Review 
This test had a nice run of not failing when it was a plain mochitest, but this is the fourth or fifth time I've seen it fail since it turned chrome.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1309495383.1309497155.17105.gz

Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test mochitest-other on 2011/06/30 21:43:03
s: talos-r3-leopard-003

10730 INFO TEST-START | chrome://mochitests/content/chrome/layout/generic/test/test_bug632379.xul
10731 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/generic/test/test_bug632379.xul | Popup should open in the same place when the menu is scrolled - got 109, expected 108
10732 INFO TEST-END | chrome://mochitests/content/chrome/layout/generic/test/test_bug632379.xul | finished in 1184ms
philor pointed out that it seems like with my patches from bug 735805, this fails consistently on Mac instead of being intermittent.  I'm updating my patchset there to make the is() a todo_is() on Mac.  Let's see if that works: <https://tbpl.mozilla.org/?tree=Try&rev=124f225b25a1>
Blocks: 663844
URL: http://mxr.mozilla.org/mozilla-centra...
Depends on: 735805
Keywords: regression
Hardware: x86 → All
(In reply to Aryeh Gregor from comment #86)
> philor pointed out that it seems like with my patches from bug 735805, this
> fails consistently on Mac instead of being intermittent.

Ftr, waitForExplicitFinish(), that bug 735805 will re-add, had been mistakenly removed by bug 675201.
Oops -- I forgot to include the fix I mentioned in comment 86 in my push.  This patch should make it a todo() on Mac instead of permanent orange.  The try run I linked to there demonstrates that it should work.
Ms2ger said to push it with r=orange, so I did:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b06cfee48cd

Hope that was the right thing to do.
Whiteboard: [orange] → [orange][Leave open after merge]
Sadly, even a blind pig finds an UNEXPECTED-PASS every now and then.
Summary: Intermittent test_bug632379.xul | Popup should open in the same place when the menu is scrolled - got 109, expected 108 since it got moved to mochitest-chrome → Intermittent TEST-UNEXPECTED-PASS test_bug632379.xul | Popup should open in the same place when the menu is scrolled - got 109, expected 108 since it got moved to mochitest-chrome
Attachment #608064 - Attachment description: Patch to change it to a todo() → Patch to change it to a todo() [Checked in: Comment 99]
Summary: Intermittent TEST-UNEXPECTED-PASS test_bug632379.xul | Popup should open in the same place when the menu is scrolled - got 109, expected 108 since it got moved to mochitest-chrome → Intermittent TEST-UNEXPECTED-PASS test_bug632379.xul | Popup should open in the same place when the menu is scrolled - 109 should equal 109 since it got moved to mochitest-chrome
(In reply to Aryeh Gregor from comment #88)
> This patch should make it a todo() on Mac

Seeing as it's already a todo (and thus not really gaining us much), could we just disable this on Mac completely for now, seeing how often the unexpected passes are occurring of late?
Attached patch Patch to disable on Mac (obsolete) — — Splinter Review 
Is already a todo_is and unexpectedly passes on too intermittent a basis for anyone to actually be paying attention to it anyway. This disables on Mac for now.
Attachment #608064 - Attachment is obsolete: true
Attachment #623153 - Flags: review?(philringnalda)
Whoops, having a Friday afternoon moment.

Is the only test in that file, so I want to be disabling for Mac in the Makefile right? Like http://mxr.mozilla.org/mozilla-central/source/browser/components/safebrowsing/content/test/Makefile.in#50 yeah?
Comment on attachment 623153 [details] [diff] [review]
Patch to disable on Mac

You have to run a test, even if that test is as stupid as "todo_is(false, "have someone who works on Widget: Cocoa")".
Attachment #623153 - Flags: review?(philringnalda) → review-
Attached patch Patch to disable on Mac v2 (obsolete) — — Splinter Review 

        Attachment #623153 -
        Attachment is obsolete: true

        Attachment #623166 -
        Flags: review?(philringnalda)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch to disable on Mac v2.1 (obsolete)
        — 
          — Splinter Review
      

    


  
Bah, trailing whitespace on previous, sorry spam.

        Attachment #623166 -
        Attachment is obsolete: true

        Attachment #623168 -
        Flags: review?(philringnalda)

        Attachment #623166 -
        Flags: review?(philringnalda)

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  


  
Disable on Mac with the |todo(false,...| just on Mac this time.

Third time lucky...

        Attachment #623168 -
        Attachment is obsolete: true

        Attachment #624104 -
        Flags: review?(philringnalda)

        Attachment #623168 -
        Flags: review?(philringnalda)

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
  

        Attachment #624104 -
        Flags: review?(philringnalda) → review+

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Disable on Mac:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b71580a40d59
Whiteboard: [orange][Leave open after merge] → [orange][leave open]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
(In reply to Ed Morley [:edmorley] from comment #755)
> Disable on Mac:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/b71580a40d59

https://hg.mozilla.org/mozilla-central/rev/b71580a40d59
Whiteboard: [orange][leave open] → [orange]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Comment on attachment 624104 [details] [diff] [review]
Disable test on Mac

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Unknown; test has been disabled on trunk.
User impact if declined: Sheriffs being driven insane.
Testing completed (on m-c, etc.): Test disabled on m-c and aurora already.
Risk to taking this patch (and alternatives if risky): Test-only.
String or UUID changes made by this patch: None.

        Attachment #624104 -
        Attachment description: Patch to disable on Mac, except like properly this time :-/ → Disable test on Mac

        Attachment #624104 -
        Flags: approval-mozilla-beta?

    
  
Whiteboard: [orange] → [orange][test disabled on mac]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Comment on attachment 624104 [details] [diff] [review]
Disable test on Mac

[Triage Comment]
Test only, approved for Beta 14.

        Attachment #624104 -
        Flags: approval-mozilla-beta? → approval-mozilla-beta+

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
  
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME

    
    

    
  
updating status flags and removing checkin-needed since I see this already landed.

          status-firefox14:
          --- → fixed
Keywords: checkin-needed

    
    

    
  
How can this be WFM, when
1) there was a patch landed.
2) the test is still disabled.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---

    
    

    
  
Whoops, mixing up my [oranges], was convinced this was one of the "WFM on trunk but disabled on beta since we don't know what to uplift that fixed it" ones. Thanks Serge :-)
Status: REOPENED → NEW

    
    

    
  
(In response to email) This was disabled on firefox15 whilst it was still on m-c, so this doesn't need uplifting to aurora15:
http://hg.mozilla.org/releases/mozilla-aurora/file/ddda87bd4a4a/layout/generic/test/test_bug632379.xul#l186 

The fixed/affected flags weren't set, since technically this isn't fixed, the test is just disabled.

          status-firefox15:
          --- → fixed
Whiteboard: [orange][test disabled on mac] → [test disabled on mac]

    
    

    
  
Comment on attachment 624104 [details] [diff] [review]
Disable test on Mac

(To get this off of the bugzilla-todos "to check in" list)

        Attachment #624104 -
        Flags: checkin+
Priority: -- → P5

    
    

    
      
  

    
  
Summary: Intermittent TEST-UNEXPECTED-PASS test_bug632379.xul | Popup should open in the same place when the menu is scrolled - 109 should equal 109 since it got moved to mochitest-chrome → Intermittent TEST-UNEXPECTED-PASS test_bug632379.xhtml,test_bug632379.xul | Popup should open in the same place when the menu is scrolled - 109 should equal 109 since it got moved to mochitest-chrome

    
  
Severity: normal → S3

    
    

    
      
  


  

    
  

        Attachment #9385927 -
        Attachment is obsolete: true

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: