668826 - Make reflectString able to test reflections with different IDL attribute and content attribute names

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

With bug 668820, I think we could allow things like this:
reflectString({
  element: myElement,
  attribute: "myAttribute",
});
and:
reflectString({
  element: myElement,
  attribute: { idl: "myIDL", content: "myContent", },
});

That would require to check the type of the 'attribute' attribute on the methods. Would you approve such a solution Ms2ger?

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Only doing that for reflectString for the moment. Should be easy to do the same thing for other methods if needed.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 544093 [details] [diff] [review]
Patch v1

>--- a/content/html/content/test/reflect.js
>+++ b/content/html/content/test/reflect.js
> function reflectString(aParameters)
> {
>   var element = aParameters.element;
>-  var attr = aParameters.attribute;
>+  var contentAttr = typeof aParameters.attribute == "string"
>+                      ? aParameters.attribute : aParameters.attribute.content;
>+  var idlAttr = typeof aParameters.attribute == "string"
>+                  ? aParameters.attribute : aParameters.attribute.idl;

===, to match the !== below.

Looks good. r=me

Comment 3

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/f9f7e6821ba6