668834 - Show "Change Language" link on about:home on firstrun

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Since we are going to skip the locale picker on firstrun when Fennec already has the system locale, we'd like to show a "Change Locale" link on about:home.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Screenshot of aboutHome with the link

I'm only showing this on firstrun, regardless of whether we've shown you the locale picker or not.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Make it a button-like thing, like "Tabs from other computers" and use "Change Language" (capital 'L' since it is a button)

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Screenshot 2

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Updated patch.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 543457 [details] [diff] [review]
Patch v2

Move the local div above the footer div. Make sure the spacing looks good.

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/788753e18492

Comment 7

[Aaron Train [:aaronmt]]

Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110704 Firefox/7.0a1 Fennec/7.0a1

Comment 8

[Aaron Train [:aaronmt]]

Litmus: http://litmus.mozilla.org/show_test.cgi?&id=22930

Comment 9

[Aaron Train [:aaronmt]]

Litmus: https://litmus.mozilla.org/show_test.cgi?&id=22931