668882 - Please! Remove <button> line-height restriction

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[steve]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build ID: 20110413222027

Steps to reproduce:

Tried to set the line-height on a <button>


Actual results:

Firefox ignored the entry. IE 8 handles it correctly.


Expected results:

The line-height should have changed.

Apparently, the default style sheet contains this:

button, input[type="reset"], input[type="button"], input[type="submit"] {
	line-height:normal !important;
}

The "!important" apparently makes it impossible to override. Please remove the "!important". There is no reason to force this behavior, and it is a trivial change.

Comment 1

[Boris Zbarsky [:bzbarsky]]

> Apparently, the default style sheet contains this:

The <button> part of this got taken out in bug 349259, and that change was left in when the rest of that bug was backed out.  So you can't set line-height on an <input type="button">, but it works on <button> now.