Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 668882 - Please! Remove <button> line-height restriction
: Please! Remove <button> line-height restriction
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: All Other
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2011-07-01 13:46 PDT by steve
Modified: 2011-07-01 17:43 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Description steve 2011-07-01 13:46:24 PDT
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build ID: 20110413222027

Steps to reproduce:

Tried to set the line-height on a <button>

Actual results:

Firefox ignored the entry. IE 8 handles it correctly.

Expected results:

The line-height should have changed.

Apparently, the default style sheet contains this:

button, input[type="reset"], input[type="button"], input[type="submit"] {
	line-height:normal !important;

The "!important" apparently makes it impossible to override. Please remove the "!important". There is no reason to force this behavior, and it is a trivial change.
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2011-07-01 17:43:25 PDT
> Apparently, the default style sheet contains this:

The <button> part of this got taken out in bug 349259, and that change was left in when the rest of that bug was backed out.  So you can't set line-height on an <input type="button">, but it works on <button> now.

Note You need to log in before you can comment on or make changes to this bug.