Closed Bug 668919 Opened 8 years ago Closed 8 years ago

The ellipsis with text-overflow: ellipsis is sometimes one pixel too low

Categories

(Core :: Layout: Block and Inline, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: pcwalton, Assigned: mats)

Details

(Keywords: platform-parity, testcase, Whiteboard: [inbound])

Attachments

(4 files)

Screenshots of Panorama attached. Sometimes the ellipsis is one pixel too low for me, depending on the block sizing, but not always.
WFM in a local Linux64 mozilla-central build.  I can reproduce it on OSX
though.  A testcase would help debugging... do you know what kind of markup
are used for the text there?
Attached file Testcase #1
Testcase #1 looks fine on Linux on Windows XP.  Also when zooming up/down.

On OSX, the top three lines looks fine, on the next four the ellipsis is
too low, the bottom four looks good.
Keywords: testcase
s/Linux on Windows/Linux and Windows/
Confirmed on Mac.
Hardware: x86 → All
The problem is that nsTextFrame pixel-snaps the baseline.y before painting
the text, and we need to do the same when painting the marker text.
Should be an easy fix, just factoring out nsTextFrame::GetSnappedBaselineY
to nsLayoutUtils...
Component: Layout: Text → Layout: Block and Inline
Keywords: pp
QA Contact: layout.fonts-and-text → layout.block-and-inline
Target Milestone: --- → mozilla7
Assignee: nobody → matspal
Attachment #543626 - Flags: review?(roc)
Comment on attachment 543626 [details] [diff] [review]
fix + reftest, rev. 1

Review of attachment 543626 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #543626 - Flags: review?(roc) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/cdff167e8074
Flags: in-testsuite+
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/cdff167e8074
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.