fix-cortex-a8 linker flag not specified on Android

RESOLVED INVALID

Status

Firefox Build System
General
RESOLVED INVALID
7 years ago
5 months ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

Trunk
ARM
Android

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
The NDK5 docs mention using --fix-cortex-a8 as a required linker flag. It doesn't seem to be mentioned in NDK4 docs, but I tested the flag with NDK4 with no error.
(Assignee)

Comment 1

7 years ago
Created attachment 544295 [details] [diff] [review]
Use fix-cortex-a8 linker flag on Android (v1)
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Attachment #544295 - Flags: review?(khuey)
The binutils documentation says:

The `--fix-cortex-a8' switch enables a link-time workaround for an erratum in certain Cortex-A8 processors. The workaround is enabled by default if you are targeting the ARM v7-A architecture profile.

We are targetting ARM v7-A, so I don't think we need this flag.
Comment on attachment 544295 [details] [diff] [review]
Use fix-cortex-a8 linker flag on Android (v1)

You'll want to file a separate bug on doing this for NSPR.
Attachment #544295 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

7 years ago
(In reply to comment #2)
> The binutils documentation says:
> 
> The `--fix-cortex-a8' switch enables a link-time workaround for an erratum
> in certain Cortex-A8 processors. The workaround is enabled by default if you
> are targeting the ARM v7-A architecture profile.
> 
> We are targetting ARM v7-A, so I don't think we need this flag.

You're right. The Android NDK docs imply -march=armv7-a and --fix-cortex-a8 are separate. So I did a test and got the same binaries with and without the flag. Marking bug as invalid.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.