668925 - fix-cortex-a8 linker flag not specified on Android

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

The NDK5 docs mention using --fix-cortex-a8 as a required linker flag. It doesn't seem to be mentioned in NDK4 docs, but I tested the flag with NDK4 with no error.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use fix-cortex-a8 linker flag on Android (v1)

Comment 2

[Mike Hommey [:glandium]]

The binutils documentation says:

The `--fix-cortex-a8' switch enables a link-time workaround for an erratum in certain Cortex-A8 processors. The workaround is enabled by default if you are targeting the ARM v7-A architecture profile.

We are targetting ARM v7-A, so I don't think we need this flag.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 544295 [details] [diff] [review]
Use fix-cortex-a8 linker flag on Android (v1)

You'll want to file a separate bug on doing this for NSPR.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to comment #2)
> The binutils documentation says:
> 
> The `--fix-cortex-a8' switch enables a link-time workaround for an erratum
> in certain Cortex-A8 processors. The workaround is enabled by default if you
> are targeting the ARM v7-A architecture profile.
> 
> We are targetting ARM v7-A, so I don't think we need this flag.

You're right. The Android NDK docs imply -march=armv7-a and --fix-cortex-a8 are separate. So I did a test and got the same binaries with and without the flag. Marking bug as invalid.